Skip to content

Commit 19c80c6

Browse files
markmcnelisBridgeAR
authored andcommitted
fix: client duplicate function now allows db param to be passed
1 parent 66d5a50 commit 19c80c6

File tree

2 files changed

+4
-1
lines changed

2 files changed

+4
-1
lines changed

lib/extendedApi.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -95,7 +95,7 @@ RedisClient.prototype.duplicate = function (options, callback) {
9595
existing_options[elem] = options[elem];
9696
}
9797
var client = new RedisClient(existing_options);
98-
client.selected_db = this.selected_db;
98+
client.selected_db = options.db || this.selected_db;
9999
if (typeof callback === 'function') {
100100
var ready_listener = function () {
101101
callback(null, client);

test/node_redis.spec.js

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -120,11 +120,14 @@ describe('The node_redis client', function () {
120120
});
121121

122122
it('check if all new options replaced the old ones', function (done) {
123+
client.selected_db = 1;
123124
var client2 = client.duplicate({
125+
db: 2,
124126
no_ready_check: true
125127
});
126128
assert(client.connected);
127129
assert(!client2.connected);
130+
assert.notEqual(client.selected_db, client2.selected_db);
128131
assert.strictEqual(client.options.no_ready_check, undefined);
129132
assert.strictEqual(client2.options.no_ready_check, true);
130133
assert.notDeepEqual(client.options, client2.options);

0 commit comments

Comments
 (0)