increase coverage

Author: AvitalFineRedis

redis/commands/helpers.py

@@ -37,6 +37,10 @@ def delist(x):
 def parse_to_list(response):
     """Optimistically parse the response to a list."""
     res = []
+
+    if response is None:
+        return res
+
     for item in response:
         try:
             res.append(int(item))

redis/commands/search/commands.py

@@ -450,12 +450,9 @@ def profile(self, query, limited=False):
         elif isinstance(query, Query):
             cmd[2] = "SEARCH"
             cmd += query.get_args()
-        elif isinstance(query, str):
-            cmd[2] = "SEARCH"
-            cmd.append(query)
         else:
-            raise ValueError("Must provide AggregateRequest object, "
-                             "Query object or str.")
+            raise ValueError("Must provide AggregateRequest object or "
+                             "Query object.")
 
         res = self.execute_command(*cmd)
 

tests/test_helpers.py

@@ -5,7 +5,7 @@
     nativestr,
     parse_to_list,
     quote_string,
-    random_string
+    random_string, parse_to_dict
 )
 
 
@@ -19,11 +19,34 @@ def test_list_or_args():
 
 
 def test_parse_to_list():
+    assert parse_to_list(None) == []
     r = ["hello", b"my name", "45", "555.55", "is simon!", None]
     assert parse_to_list(r) == \
         ["hello", "my name", 45, 555.55, "is simon!", None]
 
 
+def test_parse_to_dict():
+    assert parse_to_dict(None) == {}
+    r = [['Some number', '1.0345'],
+         ['Some string', 'hello'],
+         ['Child iterators',
+          ['Time', '0.2089', 'Counter', 3, 'Child iterators',
+           ['Type', 'bar', 'Time', '0.0729', 'Counter', 3],
+           ['Type', 'barbar', 'Time', '0.058', 'Counter', 3]]]]
+    assert parse_to_dict(r) == {
+        'Child iterators': {
+            'Child iterators': [
+                {'Counter': 3.0, 'Time': 0.0729, 'Type': 'bar'},
+                {'Counter': 3.0, 'Time': 0.058, 'Type': 'barbar'}
+            ],
+            'Counter': 3.0,
+            'Time': 0.2089
+        },
+        'Some number': 1.0345,
+        'Some string': 'hello'
+    }
+
+
 def test_nativestr():
     assert nativestr('teststr') == 'teststr'
     assert nativestr(b'teststr') == 'teststr'

tests/test_search.py

@@ -1338,3 +1338,21 @@ def test_profile(client):
     assert det['Iterators profile']['Type'] == 'WILDCARD'
     assert det['Parsing time'] < 0.3
     assert len(res.rows) == 2  # check also the search result
+
+
+@pytest.mark.redismod
+def test_profile_limited(client):
+    client.ft().create_index((TextField('t'),))
+    client.ft().client.hset('1', 't', 'hello')
+    client.ft().client.hset('2', 't', 'hell')
+    client.ft().client.hset('3', 't', 'help')
+    client.ft().client.hset('4', 't', 'helowa')
+
+    q = Query('%hell% hel*')
+    res, det = client.ft().profile(q, limited=True)
+    assert det['Iterators profile']['Child iterators'][0]['Child iterators'] \
+           == 'The number of iterators in the union is 3'
+    assert det['Iterators profile']['Child iterators'][1]['Child iterators'] \
+           == 'The number of iterators in the union is 4'
+    assert det['Iterators profile']['Type'] == 'INTERSECT'
+    assert len(res.docs) == 3  # check also the search result