add type hints

Author: dvora-h

redis/commands/core.py

@@ -1,6 +1,7 @@
 import datetime
 import hashlib
 import time
+from typing import List, Optional
 import warnings
 
 from redis.exceptions import ConnectionError, DataError, NoScriptError, RedisError
@@ -1926,14 +1927,20 @@ def brpoplpush(self, src, dst, timeout=0):
             timeout = 0
         return self.execute_command("BRPOPLPUSH", src, dst, timeout)
 
-    def lmpop(self, num_keys, keys, *args, count=1):
+    def lmpop(
+        self,
+        num_keys: int,
+        *args: List[str],
+        direction: str=None,
+        count: Optional[int]=1
+        ) -> List:
         """
         Pop ``count`` values (default 1) first non-empty list key from the list
-        of provided key names.
+        of args provided key names.
 
         For more information check https://redis.io/commands/lmpop
         """
-        args = [num_keys] + list_or_args(keys, args)
+        args = [num_keys] + list(args) + [direction]
         if count != 1:
             args.extend(["COUNT", count])
 

tests/test_commands.py

@@ -1478,11 +1478,11 @@ def test_brpoplpush_empty_string(self, r):
     def test_lmpop(self, unstable_r):
         unstable_r.rpush("foo", "1", "2", "3", "4", "5")
         result = [b"foo", [b"1", b"2"]]
-        assert unstable_r.lmpop("2", "bar", "foo", "LEFT", count=2) == result
+        assert unstable_r.lmpop("2", "bar", "foo", direction="LEFT", count=2) == result
         with pytest.raises(redis.ResponseError):
-            unstable_r.lmpop("2", "bar", "foo", count=2)
+            unstable_r.lmpop("2", "bar", "foo", direction="up", count=2)
         unstable_r.rpush("bar", "a", "b", "c", "d")
-        assert unstable_r.lmpop("2", ["bar", "foo"], "RIGHT") == [b"bar", [b"d"]]
+        assert unstable_r.lmpop("2", "bar", "foo", direction="RIGHT") == [b"bar", [b"d"]]
 
     def test_lindex(self, r):
         r.rpush("a", "1", "2", "3")