-
Notifications
You must be signed in to change notification settings - Fork 2.6k
running dump() fails when decode_responses=True in a pipeline #1884
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
HI @brianmaissy |
Why doesn't it make sense to use |
@brianmaissy We should support this (and don't today), the best answer is to use a connection where deconde_responses is False. While I realize this isn't ideal, this is the best current answer. tl;dr yes a bug we should fix in the future, and labelled accordingly. |
Yeah that's the workaround I've been using. Thank you. |
Since we added the NEVER_DECODE target as part of another bug - closing this off. It works now. |
in what version is it fixed? |
I think > 4.0.1. @dvora-h am I right? |
I'm using 4.3.4, but it still doesn't work when the non-decodable command is used in a pipeline |
This issue is marked stale. It will be closed in 30 days if it is not updated. |
@brianmaissy Yes |
This issue is marked stale. It will be closed in 30 days if it is not updated. |
AFAIC this is still an issue |
Hi @brianmedigate the dump command works without issues if you don't run your pipeline in transaction mode (client.pipeline(transaction=False)). Would that work for your use case? |
Maybe. But shouldn't this be fixable regardless? |
This is an extension of issue #1254, which was partially (but I belive not fully) resolved in #1731.
I think that when non-decodable commands are called from within a pipeline, they are decoded anyway.
See my comment on the original issue here: #1254 (comment)
The text was updated successfully, but these errors were encountered: