Skip to content

running dump() fails when decode_responses=True in a pipeline #1884

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
brianmaissy opened this issue Jan 17, 2022 · 15 comments
Open

running dump() fails when decode_responses=True in a pipeline #1884

brianmaissy opened this issue Jan 17, 2022 · 15 comments
Assignees
Labels
bug Bug

Comments

@brianmaissy
Copy link

This is an extension of issue #1254, which was partially (but I belive not fully) resolved in #1731.

I think that when non-decodable commands are called from within a pipeline, they are decoded anyway.

See my comment on the original issue here: #1254 (comment)

@dvora-h
Copy link
Collaborator

dvora-h commented Jan 20, 2022

HI @brianmaissy
This is a real bug, but however it doesn't make sense to use one of these commands in a pipeline, so for now we will leave it as an open bug.

@brianmaissy
Copy link
Author

Why doesn't it make sense to use dump() in a pipeline? I do so in order to dump multiple keys.

@chayim chayim added the bug Bug label Jan 20, 2022
@chayim
Copy link
Contributor

chayim commented Jan 20, 2022

@brianmaissy We should support this (and don't today), the best answer is to use a connection where deconde_responses is False. While I realize this isn't ideal, this is the best current answer.

tl;dr yes a bug we should fix in the future, and labelled accordingly.

@brianmaissy
Copy link
Author

Yeah that's the workaround I've been using. Thank you.

@chayim
Copy link
Contributor

chayim commented Jul 13, 2022

Since we added the NEVER_DECODE target as part of another bug - closing this off. It works now.

@brianmedigate
Copy link

in what version is it fixed?

@chayim
Copy link
Contributor

chayim commented Jul 13, 2022

I think > 4.0.1. @dvora-h am I right?

@brianmedigate
Copy link

I'm using 4.3.4, but it still doesn't work when the non-decodable command is used in a pipeline

@github-actions
Copy link
Contributor

This issue is marked stale. It will be closed in 30 days if it is not updated.

@github-actions github-actions bot added the Stale label Jul 14, 2023
@brianmedigate
Copy link

@chayim @dvora-h can you please confirm that this is still open?

@github-actions github-actions bot removed the Stale label Jul 15, 2023
@dvora-h
Copy link
Collaborator

dvora-h commented Jul 16, 2023

@brianmaissy Yes

Copy link
Contributor

This issue is marked stale. It will be closed in 30 days if it is not updated.

@github-actions github-actions bot added the Stale label Sep 23, 2024
@brianmedigate
Copy link

AFAIC this is still an issue

@github-actions github-actions bot removed the Stale label Sep 26, 2024
@petyaslavova petyaslavova assigned petyaslavova and unassigned dvora-h Feb 10, 2025
@petyaslavova
Copy link
Collaborator

Hi @brianmedigate the dump command works without issues if you don't run your pipeline in transaction mode (client.pipeline(transaction=False)). Would that work for your use case?

@brianmedigate
Copy link

Maybe. But shouldn't this be fixable regardless?

@petyaslavova petyaslavova added Stale and removed Stale labels Feb 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Bug
Projects
None yet
Development

No branches or pull requests

5 participants