From 83653a25e4765e727f9ca737089667f4e0474676 Mon Sep 17 00:00:00 2001 From: "Chayim I. Kirshen" Date: Thu, 11 Aug 2022 09:10:42 +0300 Subject: [PATCH 1/2] Adding reserve as an alias for create, so that we have BF.RESERVE accuratenly supported --- redis/commands/bf/commands.py | 2 ++ tests/test_bloom.py | 15 +++++++++++++++ 2 files changed, 17 insertions(+) diff --git a/redis/commands/bf/commands.py b/redis/commands/bf/commands.py index 0fe065d708..dfda47d6b0 100644 --- a/redis/commands/bf/commands.py +++ b/redis/commands/bf/commands.py @@ -69,6 +69,8 @@ def create(self, key, errorRate, capacity, expansion=None, noScale=None): self.append_no_scale(params, noScale) return self.execute_command(BF_RESERVE, *params) + reserve = create + def add(self, key, item): """ Add to a Bloom Filter `key` an `item`. diff --git a/tests/test_bloom.py b/tests/test_bloom.py index 12a4839922..fc7829893a 100644 --- a/tests/test_bloom.py +++ b/tests/test_bloom.py @@ -38,6 +38,21 @@ def test_create(client): assert client.topk().reserve("topk", 5, 100, 5, 0.9) +@pytest.mark.redismod +def test_bf_reserve(client): + """Testing BF.RESERVE""" + assert client.bf().reserve("bloom", 0.01, 1000) + assert client.bf().reserve("bloom_e", 0.01, 1000, expansion=1) + assert client.bf().reserve("bloom_ns", 0.01, 1000, noScale=True) + assert client.cf().reserve("cuckoo", 1000) + assert client.cf().reserve("cuckoo_e", 1000, expansion=1) + assert client.cf().reserve("cuckoo_bs", 1000, bucket_size=4) + assert client.cf().reserve("cuckoo_mi", 1000, max_iterations=10) + assert client.cms().initbydim("cmsDim", 100, 5) + assert client.cms().initbyprob("cmsProb", 0.01, 0.01) + assert client.topk().reserve("topk", 5, 100, 5, 0.9) + + @pytest.mark.redismod @pytest.mark.experimental def test_tdigest_create(client): From 0f1f38f40f4907931487bf6b9f639a402b847499 Mon Sep 17 00:00:00 2001 From: dvora-h <67596500+dvora-h@users.noreply.github.com> Date: Tue, 30 Aug 2022 02:04:19 +0300 Subject: [PATCH 2/2] add reserve to cf commands --- redis/commands/bf/commands.py | 2 ++ 1 file changed, 2 insertions(+) diff --git a/redis/commands/bf/commands.py b/redis/commands/bf/commands.py index dfda47d6b0..8b2cc2cc2e 100644 --- a/redis/commands/bf/commands.py +++ b/redis/commands/bf/commands.py @@ -180,6 +180,8 @@ def create( self.append_max_iterations(params, max_iterations) return self.execute_command(CF_RESERVE, *params) + reserve = create + def add(self, key, item): """ Add an `item` to a Cuckoo Filter `key`.