Added catch to print warnings for backend missing in config.

Updated tests.

Rembed unneeded pyflakes override.

Ran sed on files to appease nitpicks.

Author: brhoades

assigner/__init__.py

@@ -7,7 +7,7 @@
 from colorlog import ColoredFormatter
 from requests.exceptions import HTTPError
 
-from assigner.backends.decorators import requires_backend_and_config
+from assigner.backends.decorators import requires_config_and_backend
 from assigner.roster_util import get_filtered_roster
 from assigner.progress import Progress
 
@@ -44,7 +44,7 @@
 ]
 
 
-@requires_backend_and_config
+@requires_config_and_backend
 def manage_repos(conf, backend, args, action):
     """Performs an action (lambda) on all student repos
     """

assigner/backends/base.py

@@ -150,7 +150,6 @@ def push_to(self, student_repo: StudentRepoBase, branch: str = "master") -> None
         raise NotImplementedError
 
 
-#pylint: disable=too-few-public-methods
 class BackendBase(object):
     """
     Common abstract base backend for all assigner backends (gitlab or mock).

assigner/backends/decorators.py

@@ -1,15 +1,25 @@
+import logging
+
 from assigner.backends import GitlabBackend, MockBackend
 from assigner.config import requires_config
 
 
-def requires_backend_and_config(func):
+logger = logging.getLogger(__name__)
+
+
+def requires_config_and_backend(func):
     """Provides a backend depending on configuration."""
     @requires_config
     def wrapper(config, cmdargs, *args, **kwargs):
-        if config.backend == "gitlab":
+        try:
+            config.backend
+        except KeyError:
+            logger.info(
+                "The 'backend' field in config is not set; it will default to Gitlab."
+            )
             return func(config, GitlabBackend, cmdargs, *args, **kwargs)
-        if config.backend == "mock":
-            return func(config, MockBackend, cmdargs, *args, **kwargs)
 
-        return func(config, GitlabBackend, cmdargs, *args, **kwargs)
+        if config.backend == "gitlab":
+            return func(config, GitlabBackend, cmdargs, *args, **kwargs)
+        return func(config, MockBackend, cmdargs, *args, **kwargs)
     return wrapper

assigner/commands/assign.py

@@ -3,7 +3,7 @@
 import time
 
 from assigner.backends.base import RepoError
-from assigner.backends.decorators import requires_backend_and_config
+from assigner.backends.decorators import requires_config_and_backend
 from assigner.commands.open import open_assignment
 from assigner.progress import Progress
 from assigner.roster_util import get_filtered_roster
@@ -15,7 +15,7 @@
 logger = logging.getLogger(__name__)
 
 
-@requires_backend_and_config
+@requires_config_and_backend
 def assign(conf, backend, args):
     """Creates homework repositories for an assignment for each student
     in the roster.

assigner/commands/canvas.py

@@ -3,7 +3,7 @@
 from prettytable import PrettyTable
 
 from assigner import make_help_parser
-from assigner.backends.decorators import requires_backend_and_config
+from assigner.backends.decorators import requires_config_and_backend
 from assigner.canvas import CanvasAPI
 from assigner.config import requires_config, DuplicateUserError
 from assigner.roster_util import add_to_roster
@@ -13,7 +13,7 @@
 logger = logging.getLogger(__name__)
 
 
-@requires_backend_and_config
+@requires_config_and_backend
 def import_from_canvas(conf, backend, args):
     """Imports students from a Canvas course to the roster.
     """

assigner/commands/get.py

@@ -5,7 +5,7 @@
 from git.exc import NoSuchPathError, GitCommandError
 
 from assigner.backends import RepoError
-from assigner.backends.decorators import requires_backend_and_config
+from assigner.backends.decorators import requires_config_and_backend
 from assigner.progress import Progress
 from assigner.roster_util import get_filtered_roster
 
@@ -16,7 +16,7 @@
 logger = logging.getLogger(__name__)
 
 
-@requires_backend_and_config
+@requires_config_and_backend
 def get(conf, backend, args):
     """
     Creates a folder for the assignment in the CWD (or <path>, if specified)

assigner/commands/import.py

@@ -2,7 +2,7 @@
 import logging
 import re
 
-from assigner.backends.decorators import requires_backend_and_config
+from assigner.backends.decorators import requires_config_and_backend
 from assigner.config import DuplicateUserError
 from assigner.roster_util import add_to_roster
 
@@ -11,7 +11,7 @@
 logger = logging.getLogger(__name__)
 
 
-@requires_backend_and_config
+@requires_config_and_backend
 def import_students(conf, backend, args):
     """Imports students from a CSV file to the roster.
     """

assigner/commands/new.py

@@ -2,14 +2,14 @@
 
 from requests.exceptions import HTTPError
 
-from assigner.backends.decorators import requires_backend_and_config
+from assigner.backends.decorators import requires_config_and_backend
 
 help = "Create a new template repo"
 
 logger = logging.getLogger(__name__)
 
 
-@requires_backend_and_config
+@requires_config_and_backend
 def new(conf, backend, args):
     """
     Creates a new template repository for an assignment so that you can add the

assigner/commands/open.py

@@ -3,7 +3,7 @@
 from requests.exceptions import HTTPError
 
 from assigner.backends.base import RepoError
-from assigner.backends.decorators import requires_backend_and_config
+from assigner.backends.decorators import requires_config_and_backend
 from assigner.roster_util import get_filtered_roster
 from assigner.progress import Progress
 
@@ -23,7 +23,7 @@ def open_assignment(repo, student, access):
             raise
 
 
-@requires_backend_and_config
+@requires_config_and_backend
 def open_all_assignments(conf, backend, args):
     """Adds each student in the roster to their respective homework
     repositories as Developers so they can pull/commit/push their work.

assigner/commands/roster.py

@@ -3,7 +3,7 @@
 from prettytable import PrettyTable
 
 from assigner import make_help_parser
-from assigner.backends.decorators import requires_backend_and_config
+from assigner.backends.decorators import requires_config_and_backend
 from assigner.config import requires_config, DuplicateUserError
 from assigner.roster_util import get_filtered_roster, add_to_roster
 
@@ -24,7 +24,7 @@ def list_students(conf, args):
     print(output)
 
 
-@requires_backend_and_config
+@requires_config_and_backend
 def add_student(conf, backend, args):
     """Add a student to the roster
     """

assigner/commands/status.py

@@ -5,7 +5,7 @@
 from prettytable import PrettyTable
 
 from assigner.backends.base import RepoError
-from assigner.backends.decorators import requires_backend_and_config
+from assigner.backends.decorators import requires_config_and_backend
 from assigner.progress import Progress
 from assigner.roster_util import get_filtered_roster
 
@@ -14,7 +14,7 @@
 logger = logging.getLogger(__name__)
 
 
-@requires_backend_and_config
+@requires_config_and_backend
 def status(conf, backend, args):
     """Retrieves and prints the status of repos"""
     hw_name = args.name

assigner/tests/utils.py

@@ -46,3 +46,4 @@ def setUp(self):
         )
 
         self.mock_config = self.mock_config_class.return_value.__enter__.return_value
+        self.mock_config.backend = "gitlab"