Skip to content

Prepare action callback should support meta without payload #176

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
markerikson opened this issue Aug 19, 2019 · 1 comment
Closed

Prepare action callback should support meta without payload #176

markerikson opened this issue Aug 19, 2019 · 1 comment

Comments

@markerikson
Copy link
Collaborator

Per #148 (comment) , it looks like you can't have meta without also having payload. We should allow both or either individually.

@markerikson
Copy link
Collaborator Author

Mmm... I'm questioning whether this is worth the effort.

The simple workaround is to have a prepare callback like () => ({payload: undefined, meta : someValue}).

I don't think it's worth complicating the types any further just to support this.

Closing for now.

( @phryneas , @Jessidhia, feel free to chime in if you feel this is relatively easily doable.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant