Skip to content

Docs: Fragment URLs doesn't work on docs #1865

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
tugberkugurlu opened this issue Jul 24, 2016 · 6 comments
Closed

Docs: Fragment URLs doesn't work on docs #1865

tugberkugurlu opened this issue Jul 24, 2016 · 6 comments

Comments

@tugberkugurlu
Copy link

Example: http://redux.js.org/docs/basics/UsageWithReact.html#presentational-and-container-components It doesn't navigate me to presentational-and-container-components element inside the page.

@markerikson
Copy link
Contributor

Yeah, it's an issue with Gitbook and the sidebar causing the page to snap back up to the top. See some of the discussion in #345 . I actually added a plugin to Redux's Gitbook config that sorta-kinda fixes things (by forcing a re-jump back to the anchor after a timeout), but looks like the last publish of the docs didn't include that plugin.

@timdorr
Copy link
Member

timdorr commented Aug 10, 2016

Sorry about this! Looking into it via the linked PR.

@timdorr
Copy link
Member

timdorr commented Sep 4, 2016

Updated and republished!

@timdorr timdorr closed this as completed Sep 4, 2016
@markerikson
Copy link
Contributor

Hmm. Going to the original hash URL linked in the issue doesn't jump anywhere - in fact, the hash gets removed from the URL entirely. The previous (busted) behavior was that you'd very briefly jump to the correct location, then snap back up to the top, while the hash stayed in the URL. Definitely doesn't seem like this is working as desired.

@timdorr
Copy link
Member

timdorr commented Sep 4, 2016

It does remove the hash, but it scrolls down for me. This link works for me: http://redux.js.org/docs/basics/UsageWithReact.html#containersfilterlinkjs

@markerikson
Copy link
Contributor

markerikson commented Sep 4, 2016

Hmm. I see the behavior you describe in Chrome (which I keep around for debugging purposes), but not in my personal FF43 instance. Pretty annoying. Also busted in another copy of FF where I disabled some addons.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants