Skip to content

Add an example which does not use create-react-app #2261

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
ioboi opened this issue Feb 23, 2017 · 6 comments
Closed

Add an example which does not use create-react-app #2261

ioboi opened this issue Feb 23, 2017 · 6 comments

Comments

@ioboi
Copy link

ioboi commented Feb 23, 2017

Do you want to request a feature or report a bug?
A feature.

What is the current behavior?
Most examples have been rewritten using create-react-app.

What is the expected behavior?
Would it be possible to add one example (could be as simple as the counter example), which does not use create-react-app. If there would be one, it could be used for guides like the Server Side Recipe.

@gaearon
Copy link
Contributor

gaearon commented Feb 23, 2017

We have one, universal.

@ioboi
Copy link
Author

ioboi commented Feb 23, 2017

Ok, thanks for pointing out universal.

@ioboi ioboi closed this as completed Feb 23, 2017
@ioboi
Copy link
Author

ioboi commented Feb 23, 2017

I thought of using an existing example for #2211 as a guide but the only two examples are universal and counter-vanilla. The existing SSR recipe guides the user through the process of setting up SSR, so I don't think I can use universal as a base.
Would another example without SSR like for example the counter or todos be feasible to add to the existing examples?

@ioboi ioboi reopened this Feb 23, 2017
@gaearon
Copy link
Contributor

gaearon commented Feb 23, 2017

I'm a bit confused. Are you looking for an SSR example of the opposite?

@ioboi
Copy link
Author

ioboi commented Feb 23, 2017

Sorry for the confusion. I would like to update the SSR recipe, which at the moment cannot be followed step by step as it's "out of sync" with the current state of the repository. (Issue #2211)

For the updated guide I would like to provide a sort of bare bone example, just containers, components, reducer and actions. The updated SSR recipe would then guide the user in adding SSR to the bare bone example.

@timdorr
Copy link
Member

timdorr commented Feb 23, 2017

For the updated guide I would like to provide a sort of bare bone example, just containers, components, reducer and actions.

That's exactly what the Example in the docs does: http://redux.js.org/docs/basics/ExampleTodoList.html

I would like to update the SSR recipe, which at the moment cannot be followed step by step as it's "out of sync" with the current state of the repository.

Let's keep track of that in #2211. If you have any ideas, a PR would be great!

@timdorr timdorr closed this as completed Feb 23, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants