Skip to content

Consider removing Internet Explorer support #4368

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
nickserv opened this issue Jun 12, 2022 · 7 comments
Closed

Consider removing Internet Explorer support #4368

nickserv opened this issue Jun 12, 2022 · 7 comments

Comments

@nickserv
Copy link
Contributor

Its official support is ending, so we could probably save a bit on Babel resource usage. This would technically be a breaking change though, not sure how we'd want to deal with that.

@Methuselah96
Copy link
Member

Would love to finally get a v5 out there with some cleaned up types. This could be a good excuse reason to do so.

@markerikson
Copy link
Contributor

@nickmccurdy There's barely anything IE relevant in this codebase :) Closest I can see looking at a build artifact is:

  for (var _len = arguments.length, funcs = new Array(_len), _key = 0; _key < _len; _key++) {
    funcs[_key] = arguments[_key];
  }

I agree it'd be nice to put out v5 at some point. My biggest questions are still around ecosystem compat with the types.

@nickserv
Copy link
Contributor Author

I'm mostly referring to how the Babel/browserslist config explicitly support IE in the build. Is that explicitly tested though?

@markerikson
Copy link
Contributor

Yeah, I'm just saying that Redux's code is so minimal, and it's so FP-oriented, that there's almost nothing in the current code that would matter for IE beyond a couple bits of ES6 syntax. So, sure, we ought to remove that setting in the next major. There just won't be much of a size difference because it's a small lib and there's only a couple tiny bits of syntax that would be affected.

@nickserv
Copy link
Contributor Author

nickserv commented Jun 12, 2022

That's fair. Would a draft PR to test changing the build, or would you rather wait until the types are more ready?

@timdorr
Copy link
Member

timdorr commented Jun 13, 2022

We can just do it now and see if there's any notable impact. If it doesn't actually do anything to the bundle (and I suspect it may not), it probably doesn't matter enough to bother.

@markerikson
Copy link
Contributor

Dead in the 5.0 alphas!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants