Skip to content

Documentaion: v0.13.3 displays old version (v0.12) with no context information #1156

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
kiddhustle opened this issue May 5, 2015 · 9 comments

Comments

@kiddhustle
Copy link

The latest version of the documentation seems to be an older version of the docs and has no reference to accessing the router via the context property (unless the way the router works has changed back to the pre-Context way).

@davidtheclark
Copy link

Yes. This documentation inconsistency combined with the deprecating-then-non-deprecating of the mixins is making this library pretty confusing to work with right now.

@mjackson
Copy link
Member

mjackson commented May 8, 2015

@kiddhustle thank you for bringing this to our attention. we'll definitely update the docs. this.context.router is no longer part of our user-facing API. it's still public API, but people shouldn't have to know about context in order to use the router.

@davidtheclark apologies for the confusion. yes, things are a bit messy right now. we're working hard on a new release that should clear up a lot of confusion very soon! see #1158

@ryanflorence
Copy link
Member

updating now

@ryanflorence
Copy link
Member

but the current docs are correct, in v0.13.3 you don't access context directly anymore

@kiddhustle
Copy link
Author

Oh OK now that's strange I recently upgraded from v0.12 to v0.13.3 and started seeing errors related to the context object. That's when I decided to switch to using the context directly.After that the errors went away.

I'll have to try reverting the code back to when I get time to investigate the problem again.

Thanks

@ryanflorence
Copy link
Member

What are the errors?

@ryanflorence
Copy link
Member

@SevereOverfl0w
Copy link

How should we continue if we wish to use ES6 classes?

@kiddhustle
Copy link
Author

OK so I've just reverted the mixin calls in my project to follow the latest documentation and everything seems to work OK now.

I think maybe some of the dependencies weren't all up to date when I last tried so that could have caused the errors I was seeing.

Sorry for the false alarm!

@lock lock bot locked as resolved and limited conversation to collaborators Jan 24, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants