Skip to content

Track session history length #1358

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
mjackson opened this issue Jun 18, 2015 · 3 comments
Closed

Track session history length #1358

mjackson opened this issue Jun 18, 2015 · 3 comments

Comments

@mjackson
Copy link
Member

In order to provide a reliable canGo(n) implementation in browsers, we need to know the length of the current session history. This would also allow us to return a boolean value from go(n) so callers could know if the navigation actually succeeded or not.

The way to do this would be to keep a current value in session state. I think we could reliably do this if we refactored BrowserHistory to use sessionStorage the same way that HashHistory does.
@mjackson mjackson mentioned this issue Jun 20, 2015
Closed
@agundermann
Copy link
Contributor

So pretty much #843 ?

@mjackson
Copy link
Member Author

@taurose Yes, exactly. Sorry, when you submitted #843 I wasn't yet capable of understanding everything that was going on there. I needed a little time to think over the problem myself so I could get it.

If you're up for it, I'd definitely welcome that functionality now. Maybe we could roll it into #1376?

@knowbody
Copy link
Contributor

knowbody commented Sep 9, 2015

I believe this is resolved by #1376

@knowbody knowbody closed this as completed Sep 9, 2015
@lock lock bot locked as resolved and limited conversation to collaborators Jan 23, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@mjackson @agundermann @knowbody