Skip to content

PathUtils.withQuery bug, calls Path.withoutQuery instead of PathUtils.withoutQuery, examples fail #979

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
joekrill opened this issue Mar 21, 2015 · 1 comment
Closed

PathUtils.withQuery bug, calls Path.withoutQuery instead of PathUtils.withoutQuery, examples fail #979

joekrill opened this issue Mar 21, 2015 · 1 comment

Comments

@joekrill
Copy link
Contributor

When I tried to run the examples I noticed I was getting a "Path is undefined". Looks like a minor typo on line 154 of modules/PathUtils.js introduced in commit 4a8b756:

return Path.withoutQuery(path);

should be

return PathUtils.withoutQuery(path);
@joekrill joekrill mentioned this issue Mar 21, 2015
Merged
gaearon referenced this issue Mar 24, 2015
@gaearon
Merge pull request #980 from joekrill/Fix-issue-#979
46ee7c4 
Update PathUtils.js
@gaearon
Copy link
Contributor

gaearon commented Mar 24, 2015

Fixed, thanks.

@gaearon gaearon closed this as completed Mar 24, 2015
@lock lock bot locked as resolved and limited conversation to collaborators Jan 24, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@joekrill @gaearon