Skip to content

fix import path of intersection-observer dependency in sentinel #124

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 4, 2020
Merged

fix import path of intersection-observer dependency in sentinel #124

merged 1 commit into from
May 4, 2020

Conversation

seanstrom
Copy link
Contributor

Description and Motivation

There seems to be a runtime error due to importing the IntersectionObserver component incorrectly. This leads to the List component hitting a "component is undefined" error in the browser.

Here's a link to a codesandbox demonstrating the error:
https://codesandbox.io/s/kind-bhaskara-4eznk?file=/src/App.js

How has this been tested?

  • I built, linked, and bundled a local copy of the project into a client app.
  • I ran the local test suite and storybook components server.

Note:

It seems like the test suite mocks the IntersectionObserver component dependency, so that may effect its passing results.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project
  • My change requires a change to the documentation
  • I have updated the documentation accordingly
  • I have read the CONTRIBUTING document
  • I have added tests to cover my changes
  • All new and existing tests passed

@danez
Copy link
Contributor

danez commented May 1, 2020

I guess this is the same issue as with the tests here #124

@Rendez Rendez merged commit 0145a67 into researchgate:master May 4, 2020
Rendez pushed a commit that referenced this pull request May 4, 2020
## [3.0.10](v3.0.9...v3.0.10) (2020-05-04)

### Bug Fixes

* fix import path of intersection-observer dependency in sentinel ([#124](#124)) ([659afa8](659afa8))
@danez danez mentioned this pull request May 4, 2020
@seanstrom seanstrom deleted the fix-import-path branch May 4, 2020 16:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants