-
-
Notifications
You must be signed in to change notification settings - Fork 2.3k
RestClientOptions
and its properties should have setters
#2027
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
I disagree that the options object exposed via the In short:
What you want is to support the authentication flow and reuse the client to make the authentication call before making other calls. However, it's a completely different issue compared to making the options mutable. |
Thank you @alexeyzimarev , I agree with your statement, so the feature request remains. The |
Isn't it a duplicate of #2024 |
Duplicate issue created! Closing in 15 seconds... |
Sorry about that, the repo ranger is too aggressive |
Uh oh!
There was an error while loading. Please reload this page.
It is related to changes that happened within the #1963 scope
Use case:
It is a common practice that the Authentication token is not provided during the initialization of the
RestClient
and has to be fetched later from a specific URI (eg. "/auth").This was working in
v108
:This is a workaround in
v109
:Outcomes:
Instanciating 2
RestClient
just to change one (or more) properties inOptions
is not optimal. My humble opinion is to create an instance ofRestClient
and to be able to change just the specific properties you may require.The text was updated successfully, but these errors were encountered: