Skip to content

2.4.10 release #301

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
10 tasks done
srh opened this issue Oct 5, 2023 · 10 comments
Closed
10 tasks done

2.4.10 release #301

srh opened this issue Oct 5, 2023 · 10 comments
Labels
enhancement New feature or request not qualified The issue is not checked yet by the owners question Further information is requested

Comments

@srh
Copy link
Contributor

srh commented Oct 5, 2023

With fixes for Python 3.10-3.12, this driver needs a 2.4.10 release.

@srh srh added enhancement New feature or request question Further information is requested not qualified The issue is not checked yet by the owners labels Oct 5, 2023
@lsabi
Copy link
Contributor

lsabi commented Oct 11, 2023

@srh The last but one point has been merged into the master codebase. For reference #303

The last point has been carried out on a separate branch a while ago from me. See https://github.com/rethinkdb/rethinkdb-python/tree/lsabi/commands. Since I started it, there have been some changes in the master branch, thus some adjustments shall be done. Furthermore, the commands were not complete and are probably missing something.

@srh
Copy link
Contributor Author

srh commented Oct 11, 2023

@lsabi I was imprecise -- I meant the rethinkdb dump and rethinkdb restore commands. I tried them out and they worked. Also, they work by using the _import and _export modules that the import and export command line commands use directly.

@lsabi
Copy link
Contributor

lsabi commented Oct 12, 2023

@srh no problem. Then everything is completed for now. I shall check my branch if it's worth keeping or not.

@srh
Copy link
Contributor Author

srh commented Oct 24, 2023

My understanding is, that branch has stuff not in master that you wanted to develop. I'd like to pop off this small release because there are Python 3.10-3.12 users who can't use all features of the driver right now.

@lsabi
Copy link
Contributor

lsabi commented Oct 25, 2023

The idea was to refactor the entire codebase in order to make more readable and support the latest python versions. Unfortunately, time has been against us and couldn't finish it before new versions/features were released.

I need to figure out how the building automation works. @gabor-boros can you help?

@lsabi
Copy link
Contributor

lsabi commented Oct 30, 2023

@gabor-boros I think I do not have the permissions to self-review my own PRs. Can you review it?

@fdemian
Copy link

fdemian commented Nov 3, 2023

Hi, everyone.
I'm using this driver as well and having problems with async support and it seems like this new release would solve them.
Is there anything I can do to hep this issue move forward?

@gabor-boros
Copy link
Member

Closing this PR as the new version is just released: https://pypi.org/project/rethinkdb/

@srh
Copy link
Contributor Author

srh commented Nov 14, 2023

Thanks @gabor-boros ! I've added a v2.4.10 tag and given it a GitHub release page: https://github.com/rethinkdb/rethinkdb-python/releases/tag/v2.4.10

@gabor-boros
Copy link
Member

Oh, I forgot to push the tag. Anyway, thanks @srh!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request not qualified The issue is not checked yet by the owners question Further information is requested
Projects
None yet
Development

No branches or pull requests

4 participants