feat: allow request middleware to set a response to bypass downloader

[aaronflorey]

No description provided.

[aaronflorey]

once/if you accept my two PRs, i'll submit PRs for new adapters to use the new code, as well as a PR for the docs

[ksassnowski]

Can you please also add tests for the new code? There should be tests to check that

• Requests with set responses should not get sent
• Requests with set responses still get passed through the middleware stack (i.e. they get passed to onResponseReceived)
• withResponse returns a new request with the provided response set but does not alter the original request

You can look at the existing DownloaderTest and RequestTest tests for reference. Let me know if you need help implementing the tests.

[ksassnowski]

i'll submit PRs for new adapters to use the new code

Can you clarify what you mean by adapters?

[aaronflorey]

i'll submit PRs for new adapters to use the new code

Can you clarify what you mean by adapters?

Sorry, i meant the new classes like RedisQueue and CacheMiddleware.

Thanks for the feedback, sorry that you had to flag so many issues, i'll fix them soon!

[ksassnowski]

I had a few more comments on the tests but looks good otherwise 👍 You can ignore the failing commit lint action for now as I will squash the commit anyway and can fix it then.

[aaronflorey]

Thank you for your patience!

[ksassnowski]

Can you have look at the merge conflict? Looks good otherwise!

[ksassnowski]

Thanks for the contribution!

Sorry, i meant the new classes like RedisQueue and CacheMiddleware.

Please hold off on this for a bit because I'm not sure yet if I want to include a caching middleware in the core library yet. It would be a useful third-party package, however.

PRs to the docs would be appreciated though 😊