Skip to content

"Table Header Should Contain" might get <th> elements from footer #1437

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
php-coder opened this issue Aug 29, 2019 · 5 comments
Closed

"Table Header Should Contain" might get <th> elements from footer #1437

php-coder opened this issue Aug 29, 2019 · 5 comments

Comments

@php-coder
Copy link

Table Header Should Contain keyword is looking for <th> elements everywhere in a table:

def _find_by_header(self, table_locator, content):
return self._find(table_locator, '//th', content)

Given that <th> tag can be enclosed within <tfoot>, it doesn't seem right to treat it as a header.

It seems like a bug.

@aaltat
Copy link
Contributor

aaltat commented Aug 29, 2019

Interesting, would it possible to get static HTML page and simple test case that demonstrates the problem?

@php-coder
Copy link
Author

Thank you for the fast reply!
Yes, sure I'll prepare test cases on weekend.

@aaltat
Copy link
Contributor

aaltat commented Sep 18, 2019

Would you have an update to the case?

@php-coder
Copy link
Author

I'm sorry I wasn't able to find time for that :-( Ok, probably, I won't provide it then.

@aaltat
Copy link
Contributor

aaltat commented Sep 18, 2019

I do not have time investigate this in the near future. Therefore I am closing this issue. If you @php-coder want to return in the issue, please reopen the issue.

@aaltat aaltat closed this as completed Sep 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants