Fix for issue #65 - ElementFinder.find should return [] when WebDriver.find* returns None #151
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
accidentally made changes in my master, will resubmit from branch |
|
@ombre42 Were you going to resubmit this pull request? Or I could just cherry pick it out and merge it rtomac? It looks good to me and I'm not sure it matters that it was made in your master as compared to a branch. |
|
I already did as pull request 154, but now I have doubts about whether those changes go far enough - see my comments there |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sorry this took so long to do. Thanks for all your hard work.