Temporary fix for missing VERSION string after removing metadata.py. #16
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Forgot to mention, I called this "temporary" in that to fix this issue of now missing VERSION number I simply added it to the file. But this means that it is located in two places. I have no problem with this but others might see differently and want a better solution (like the one in the decorator package). |
j1z0
added a commit
that referenced
this pull request
Dec 12, 2011
Temporary fix for missing VERSION string after removing metadata.py.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should be the last fix in moving away from static libraries and refactoring setup.py. Realized that the version string was needed elsewhere and removing metadata.py broke the package.