-
Notifications
You must be signed in to change notification settings - Fork 783
Added Get Text function to support original Selenium Library. #21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…and it brakes my tests without it :)
…e3c691dc8068fecdcc459e6a04a20842714d
…f041df22114f7c3a0d3e5e314ced35ad54/src/Selenium2Library/keywords/_browsermanagement.py
Hi Jouk0 can you add some tests around the iFrame locator functionality change? If so I think it's OK to merge. Thanks, |
I don't know how to add test yet, so I will learn from Jouko this time, Tks! Adam |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This get_text is fine I'll go ahead and add it to the base, I'm not sure about the iFrame stuff though. Ed / Ryan any thought on the iFrame stuff?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have tested the iFrame related code in my real projects. They works fine, and the logic is very simple. Please merge into base as well, tks!
Can u guys checkout the Iframes branch and see if works for u. |
i will try it. |
any updates? |
Any updates? I need to be able to do Get Text for some of my tests, unless anyone has a workaround |
@alistair-broomhead, @jollychang: I've cherry-picked out the 'get text' patch here and am having @j1z0 review it. Should be merged in soon. |
merged. :)
|
I'm closing this issues as the cherry-picked version from @emanlove has been merged into master |
... it brakes my tests without it :)