added iframe support, by allowing the element finder to handle filters w... #41
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ok here is my attempt at getting frames to work in painless manner. Basically I changed the element_finder functionality so that the filter could handled a list of tags. ie. ['frame','iframe'] as opposed to a single tag. This also required some changes to the xpath generation for find by default stuff.
Also I updated all the appropriate functions that have to do with frames to look for both frames and frames. Finally I added a couple of tests.
All the test pass. But I'm would be interested in feedback, especially if there is a way to make the code cleaner... cooler... nicer :)