TClassEdit::GetNameForIO now returns typename with trailing stars.

Since the function also strip the unique_ptr from the inside template parameters, we can not
tell from 'just' a name 'update/change' whether the IO type is a pointer or a non-pointer
template instance.

Author: pcanal

core/foundation/src/TClassEdit.cxx

@@ -2062,6 +2062,7 @@ class NameCleanerForIO {
          // ROOT-9933: we remove const if present.
          TClassEdit::TSplitType tst(name.c_str());
          tst.ShortType(name, 1);
+         name += "*";
          fHasChanged = true;
          return name;
       }
@@ -2106,7 +2107,7 @@ std::string TClassEdit::GetNameForIO(const std::string& templateInstanceName,
    auto nameForIO = node.ToString();
    if (hasChanged) {
       *hasChanged = node.HasChanged();
-      }
+   }
    return nameForIO;
 }
 

core/foundation/test/testClassEdit.cxx

@@ -247,11 +247,13 @@ TEST(TClassEdit, SplitFuncErrors)
 // ROOT-9926
 TEST(TClassEdit, GetNameForIO)
 {
-   const std::vector<std::pair<std::string, std::string>> names{{"T", "unique_ptr<const T>"},
-                                                                {"T", "unique_ptr<const T*>"},
-                                                                {"T", "unique_ptr<const T* const*>"},
-                                                                {"T", "unique_ptr<T * const>"},
-                                                                {"T", "unique_ptr<T * const**const**&* const>"}};
+   const std::vector<std::pair<std::string, std::string>> names{{"T*", "unique_ptr<const T>"},
+                                                                {"T*", "unique_ptr<const T*>"},
+                                                                {"T*", "unique_ptr<const T* const*>"},
+                                                                {"T*", "unique_ptr<T * const>"},
+                                                                {"T*", "unique_ptr<T * const**const**&* const>"},
+                                                                {"vector<T*>", "vector<unique_ptr<T>>"},
+                                                                {"vector<const T*>", "vector<unique_ptr<const T>>"}};
    for (auto &&namesp : names) {
       EXPECT_EQ(namesp.first, TClassEdit::GetNameForIO(namesp.second.c_str()))
          << "Failure in transforming typename " << namesp.first << " into " << namesp.second;

core/meta/src/TStreamerElement.cxx

@@ -1743,13 +1743,12 @@ TStreamerSTL::TStreamerSTL(const char *name, const char *title, Int_t offset,
    std::string inside = (inside_type.find("const ")==0) ? inside_type.substr(6) : inside_type;
 
    // Let's treat the unique_ptr case
-   bool nameChanged = false;
-   std::string intype = TClassEdit::GetNameForIO(inside, TClassEdit::EModType::kNone, &nameChanged);
+   std::string intype = TClassEdit::GetNameForIO(inside, TClassEdit::EModType::kNone);
 
-   bool isPointer = nameChanged; // unique_ptr is considered a pointer
+   bool isPointer = false;
    // The incoming name is normalized (it comes from splitting the name of a TClass),
    // so all we need to do is drop the last trailing star (if any) and record that information.
-   while (!nameChanged && intype[intype.length()-1] == '*') {
+   while (intype[intype.length()-1] == '*') {
       isPointer = true;
       intype.pop_back();
    }

io/io/src/TGenCollectionProxy.cxx

@@ -325,13 +325,12 @@ TGenCollectionProxy::Value::Value(const std::string& inside_type, Bool_t silent,
    fKind = kNoType_t;
 
    // Let's treat the unique_ptr case
-   bool nameChanged = false;
-   std::string intype = TClassEdit::GetNameForIO(inside, TClassEdit::EModType::kNone, &nameChanged);
+   std::string intype = TClassEdit::GetNameForIO(inside, TClassEdit::EModType::kNone);
 
-   bool isPointer = nameChanged; // unique_ptr is considered a pointer
+   bool isPointer = false;
    // The incoming name is normalized (it comes from splitting the name of a TClass),
    // so all we need to do is drop the last trailing star (if any) and record that information.
-   if (!nameChanged && intype[intype.length()-1] == '*') {
+   if (intype[intype.length()-1] == '*') {
       isPointer = true;
       intype.pop_back();
       if (intype[intype.length()-1] == '*') {

io/io/src/TStreamerInfo.cxx

@@ -437,10 +437,11 @@ void TStreamerInfo::Build(Bool_t isTransient)
       bool nameChanged;
       trueTypeNameBuf = typeNameBuf = TClassEdit::GetNameForIO(dmFull, TClassEdit::EModType::kNone, &nameChanged);
       if (nameChanged) {
-         if (TClassEdit::IsUniquePtr(dmFull)) {
+         if (trueTypeNameBuf.back() == '*') {
             dmIsPtr = true;
+            typeNameBuf.pop_back();
+            while(typeNameBuf.back() == '*') typeNameBuf.pop_back();
          }
-         while(typeNameBuf.back() == '*') typeNameBuf.pop_back();
          dmFull = trueTypeNameBuf.c_str();
          dmType = typeNameBuf.c_str();
       }
@@ -2044,7 +2045,7 @@ void TStreamerInfo::BuildOld()
 
       TDataMember* dm = 0;
 
-      std::string typeNameBuf;
+      std::string typeNameBuf;  // Keep underlying buffer alive until actually used.
       const char* dmType = nullptr;
       Bool_t dmIsPtr = false;
       TDataType* dt(nullptr);
@@ -2082,7 +2083,11 @@ void TStreamerInfo::BuildOld()
             Bool_t nameChanged;
             typeNameBuf = TClassEdit::GetNameForIO(dmType, TClassEdit::EModType::kNone, &nameChanged);
             if (nameChanged) {
-               dmIsPtr = TClassEdit::IsUniquePtr(dmType);
+               if (typeNameBuf.back() == '*') {
+                  dmIsPtr = true;
+                  typeNameBuf.pop_back();
+                  while(typeNameBuf.back() == '*') typeNameBuf.pop_back();
+               }
                dmType = typeNameBuf.c_str();
             }
             if ((isStdArray = TClassEdit::IsStdArray(dmType))){ // We tackle the std array case