[tmva] assert is ignored in Release mode, so return null

ferdymercury · guitargeek · commit 69d57cddc086 · 2024-04-28T23:36:27.000+02:00
Fixes https://its.cern.ch/jira/browse/ROOT-9918
diff --git a/tmva/tmva/src/ClassifierFactory.cxx b/tmva/tmva/src/ClassifierFactory.cxx
@@ -101,6 +101,7 @@ TMVA::IMethod* TMVA::ClassifierFactory::Create( const std::string &name,
    if (it == fCalls.end()) {
       std::cerr << "ClassifierFactory<>::Create - don't know anything about " << name << std::endl;
       assert(0);
+      return nullptr;
    }
 
    return (it->second)(job, title, dsi, option);
@@ -123,6 +124,7 @@ TMVA::IMethod* TMVA::ClassifierFactory::Create( const std::string &name,
    if (it == fCalls.end()) {
       std::cerr << "ClassifierFactory<>::Create - don't know anything about " << name << std::endl;
       assert(0);
+      return nullptr;
    }
 
    return (it->second)("", "", dsi, weightfile);

Original file line number	Diff line number	Diff line change
`@@ -101,6 +101,7 @@ TMVA::IMethod* TMVA::ClassifierFactory::Create( const std::string &name,`
`101`	`101`	`if (it == fCalls.end()) {`
`102`	`102`	`std::cerr << "ClassifierFactory<>::Create - don't know anything about " << name << std::endl;`
`103`	`103`	`assert(0);`
	`104`	`+ return nullptr;`
`104`	`105`	`}`
`105`	`106`
`106`	`107`	`return (it->second)(job, title, dsi, option);`
`@@ -123,6 +124,7 @@ TMVA::IMethod* TMVA::ClassifierFactory::Create( const std::string &name,`
`123`	`124`	`if (it == fCalls.end()) {`
`124`	`125`	`std::cerr << "ClassifierFactory<>::Create - don't know anything about " << name << std::endl;`
`125`	`126`	`assert(0);`
	`127`	`+ return nullptr;`
`126`	`128`	`}`
`127`	`129`
`128`	`130`	`return (it->second)("", "", dsi, weightfile);`