-
Notifications
You must be signed in to change notification settings - Fork 1.3k
Changes in Clang do not rebuild Clad #7977
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Not sure who to assign, feel free to change... |
I am not sure how we can fix this issue. The cmake That would fix this problem but introduce another one -- clad would be rebuilt every time one types I think we have several options: a) close the bug and ignore that type of errors (which can waste dev debug time); b) add BUILD_ALWAYS and waste a lot of user/dev time; c) check if it is feasible to somehow track changes in the source code within the regular cmake (which probably has proven hard and people added the BUILD_ALWAYS option). |
I'm ok to close this; it will probably pop up again in the future, but I agree that rebuilding Clad every time is a higher time sink for the team than one developer having to investigate weird failures. And by now, we hopefully have a sufficient understanding that it will take less time in the future because we know how to "fix" it. |
Since @hahnjo is OK to close it, we close it. Please do not hesitate to re-open in case more information becomes available that suggests to revisit this decision. |
Let's close it. It is annoying but the |
Ok, but it's not fixed in 6.30.06! I've adjusted the projects accordingly. |
Describe the bug
As seen in #7488, changing headers / data structures in Clang doesn't rebuild Clad and causes very weird test failures.
Expected behavior
The build system should detect the changes and rebuild Clad as well as
libCling.so
as needed.To Reproduce
Apply / Revert #7488 to see a crash or just touch Clang header files and observe that Clad isn't rebuilt.
The text was updated successfully, but these errors were encountered: