-
Notifications
You must be signed in to change notification settings - Fork 6
Reapply "stop the crash" #74
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
This reverts commit 0771d10.
when I remove the rprintln! from the volume instantiation match arm, the log continues.. here is the log after I make that edit: 01:11:56.020: SD card initialized successfully. |
the |
another thing to consider here is that there is no 'unmount' and we may ought to unmount it when switching from sd logging to usb mounted by crumprutr |
Looks like the crash was just something to do with the rprintln, the other functionality in your logging is correct. it looks like you have a temperature ring configured? |
i have been getting really weird stack trace behavior when there is a UTF8 decoding error, so that might have been what happened with your rprintln. The SD card stuff works reliably currently, and this branch does not contain any of the USB stuff (which you are correct in noting does indeed require an 'unmount') |
This reverts the revert commit 0771d10.
Main dies at an exception with this log:
...
01:11:56.020: SD card initialized successfully.
01:11:56.020: set up sdcard
01:11:56.020: set up volume
<hard exception here and I couldn't get anything out of the stack where it was, like it jumped away>