Skip to content

Commit 272b9fc

Browse files
committed
Avoid having undefined method on assert_nothing_raised
1 parent 6e14dcf commit 272b9fc

File tree

5 files changed

+14
-29
lines changed

5 files changed

+14
-29
lines changed

lib/rspec/rails.rb

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,6 @@
88
# Load the rspec-rails parts
99
require 'rspec/rails/view_rendering'
1010
require 'rspec/rails/matchers'
11-
require 'rspec/rails/active_support_testing_assertion'
1211
require 'rspec/rails/fixture_support'
1312
require 'rspec/rails/file_fixture_support'
1413
require 'rspec/rails/fixture_file_upload_support'

lib/rspec/rails/active_support_testing_assertion.rb

Lines changed: 0 additions & 13 deletions
This file was deleted.

lib/rspec/rails/configuration.rb

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -71,6 +71,9 @@ def self.initialize_configuration(config) # rubocop:disable Metrics/MethodLength
7171
config.add_setting :fixture_path
7272
config.include RSpec::Rails::FixtureSupport, :use_fixtures
7373

74+
# Prevent test from failing on undefined method used in ActiveSupport testing helpers
75+
config.include ActiveSupport::Testing::Assertions
76+
7477
# We'll need to create a deprecated module in order to properly report to
7578
# gems / projects which are relying on this being loaded globally.
7679
#
@@ -85,10 +88,6 @@ def self.initialize_configuration(config) # rubocop:disable Metrics/MethodLength
8588
config.include RSpec::Rails::FileFixtureSupport
8689
end
8790

88-
if ::Rails.version.to_f >= 6.1
89-
config.include RSpec::Rails::ActiveSupportTestingAssertion
90-
end
91-
9291
# Add support for fixture_path on fixture_file_upload
9392
config.include RSpec::Rails::FixtureFileUploadSupport
9493

@@ -174,6 +173,7 @@ def filter_rails_from_backtrace!
174173
end
175174
end
176175

176+
177177
if RSpec::Rails::FeatureCheck.has_action_mailer?
178178
config.include RSpec::Rails::MailerExampleGroup, type: :mailer
179179
config.after { ActionMailer::Base.deliveries.clear }

spec/rspec/rails/active_support_testing_assertion_spec.rb

Lines changed: 0 additions & 11 deletions
This file was deleted.

spec/rspec/rails/configuration_spec.rb

Lines changed: 10 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -297,4 +297,14 @@ def welcome(to:)
297297
it "has a default #file_fixture_path of 'spec/fixtures/files'" do
298298
expect(config.file_fixture_path).to eq("spec/fixtures/files")
299299
end
300+
301+
describe 'ActiveSupport::Testing::Assertions requirements' do
302+
it 'does not raise that "assert_nothing_raised" is not undefined' do
303+
expect {
304+
assert_nothing_raised do
305+
:foo
306+
end
307+
}.to_not raise_error
308+
end
309+
end
300310
end

0 commit comments

Comments
 (0)