Skip to content
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.

Commit 31c0dff

Browse files
committedDec 30, 2021
Stop using the deceiving continue-on-error
Build jobs appear as green even though they actually fail. A better approach is to mark jobs as "required" in branch protection. This way failed jobs are red, but this doesn't prevent the PR from being merged upon at maintainers' discretion.
1 parent 84d3ba3 commit 31c0dff

File tree

1 file changed

+1
-3
lines changed

1 file changed

+1
-3
lines changed
 

‎.github/workflows/ci.yml

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -18,11 +18,9 @@ jobs:
1818
include:
1919
# Edge Rails (7.0) builds >= 2.7
2020
- ruby: 3.0
21-
allow_failure: true
2221
env:
2322
RAILS_VERSION: 'main'
2423
- ruby: 2.7
25-
allow_failure: true
2624
env:
2725
RAILS_VERSION: 'main'
2826

@@ -98,4 +96,4 @@ jobs:
9896
- run: script/clone_all_rspec_repos
9997
- run: bundle install --binstubs
10098
- run: script/run_build
101-
continue-on-error: ${{ matrix.allow_failure || false }}
99+
continue-on-error: false

0 commit comments

Comments
 (0)
Please sign in to comment.