Assert EncodedString fails splitting a string with invalid byte sequence

Author: bf4

spec/rspec/support/encoded_string_spec.rb

@@ -22,23 +22,23 @@ module RSpec::Support
       end
 
       describe '#to_s' do
-        if RUBY_VERSION == '1.9.2' && RSpec::Support::Ruby.mri?
+        if RUBY_VERSION == '1.9.2' && Ruby.mri?
           it 'does nothing to an invalid byte sequence' do
             source_encoding = Encoding.find('UTF8-MAC')
             incompatible_encoding = Encoding.find('IBM737')
-            string = "\xEF hi I am not going to work".force_encoding(source_encoding)
+            string = "\xEF hi I am not going to change".force_encoding(source_encoding)
             resulting_string = build_encoded_string(string, incompatible_encoding)
 
-            expect(resulting_string.to_s).to eq("\xEF hi I am not going to work")
+            expect(resulting_string.to_s).to eq("\xEF hi I am not going to change".force_encoding(incompatible_encoding))
           end
 
           it 'does nothing to unconvertable characters' do
             source_encoding = Encoding.find('UTF-16LE')
             incompatible_encoding = Encoding.find('IBM737')
-            string = "\xEF hi I am not going to work".force_encoding(source_encoding)
+            string = "\xEF hi I am not going to change".force_encoding(source_encoding)
             resulting_string = build_encoded_string(string, incompatible_encoding)
 
-            expect(resulting_string.to_s).to eq("\xEF hi I am not going to work")
+            expect(resulting_string.to_s).to eq("\xEF hi I am not going to change".force_encoding(incompatible_encoding))
           end
         else
 
@@ -102,6 +102,14 @@ module RSpec::Support
       end
 
       describe '#split' do
+        it 'fails to split a string with an invalid byte sequence' do
+          message_with_invalid_byte_sequence = "\xEF \255 \xAD I have bad bytes".force_encoding(target_encoding)
+          resulting_string = build_encoded_string(message_with_invalid_byte_sequence, target_encoding)
+          expect {
+            resulting_string.split("\n")
+          }.to raise_error(ArgumentError)
+        end
+
         it 'splits the string based on the delimiter accounting for encoding' do
           wrapped_string = "aaaaaaaaaaa#{ascii_arrow_symbol}aaaaa".force_encoding("ASCII-8BIT")