Invalid Swagger Schema - Delete

[lstanden]

The following example method creates an invalid schema:

params do
  options :test_ids, type: Array[String], documentation: { param_type: 'body' }
  options :rest_ids, type: Array[String], documentation: { param_type: 'body' }
end
delete do
  # ...
end

[lstanden]

The schema contains multiple in: "body" records, which is invalid for the swagger schema. It should have been extracted out to a ref.

[lstanden]

I added the following monkey patch to my app, and it appears to resolve the invalid schema issues. It seems the logic is simply flawed in these existing methods:

module GrapeSwagger
  module DocMethods
    class MoveParams
      class << self
        def can_be_moved?(params, http_verb)
          includes_body_param?(params)
        end

        def should_expose_as_array?(params)
          false
        end

        def should_correct_array?(param)
          false
        end
      end
    end
  end
end

[darren987469]

@lstanden The multiple in: 'body' are combined in GrapeSwagger::DocMethods::MoveParams , which not support delete method.

grape-swagger/lib/grape-swagger/doc_methods/move_params.rb

Lines 218 to 220 in 8e4a39c

	def move_methods
	[:post, :put, :patch, 'POST', 'PUT', 'PATCH']
	end

[lstanden]

Yes, I'm aware of this @darren987469 ... by not having DELETE included, it is generating invalid swagger schema.