Skip to content

Commit b6a8224

Browse files
mterada1228kou
andauthored
Add missing RDoc::RubygemsHook API for gem server (#1270)
This PR fixes #1269. ## Expected Behavior `gem server` command is successful. ```console $ gem server Server started at http://[::]:8808 Server started at http://0.0.0.0:8808 ``` http://127.0.0.1:8808/ works. ## Actual Behavior `gem server` command doesn't work because `Gem::RDoc.load_rdoc` raises `NoMethodError`. ```console $ gem server ERROR: While executing gem ... (NoMethodError) undefined method 'load_rdoc' for class RDoc::RubygemsHook Gem::RDoc.load_rdoc ^^^^^^^^^^ /Users/mterada/.rbenv/versions/3.4.1/lib/ruby/gems/3.4.0/gems/rubygems-server-0.3.0/lib/rubygems/server.rb:437:in 'Gem::Server#initialize' /Users/mterada/.rbenv/versions/3.4.1/lib/ruby/gems/3.4.0/gems/rubygems-server-0.3.0/lib/rubygems/server.rb:426:in 'Class#new' /Users/mterada/.rbenv/versions/3.4.1/lib/ruby/gems/3.4.0/gems/rubygems-server-0.3.0/lib/rubygems/server.rb:426:in 'Gem::Server.run' /Users/mterada/.rbenv/versions/3.4.1/lib/ruby/gems/3.4.0/gems/rubygems-server-0.3.0/lib/rubygems/commands/server_command.rb:83:in 'Gem::Commands::ServerCommand#execute' /Users/mterada/.rbenv/versions/3.4.1/lib/ruby/3.4.0/rubygems/command.rb:326:in 'Gem::Command#invoke_with_build_args' /Users/mterada/.rbenv/versions/3.4.1/lib/ruby/3.4.0/rubygems/command_manager.rb:253:in 'Gem::CommandManager#invoke_command' /Users/mterada/.rbenv/versions/3.4.1/lib/ruby/3.4.0/rubygems/command_manager.rb:194:in 'Gem::CommandManager#process_args' /Users/mterada/.rbenv/versions/3.4.1/lib/ruby/3.4.0/rubygems/command_manager.rb:152:in 'Gem::CommandManager#run' /Users/mterada/.rbenv/versions/3.4.1/lib/ruby/3.4.0/rubygems/gem_runner.rb:57:in 'Gem::GemRunner#run' /Users/mterada/.rbenv/versions/3.4.1/bin/gem:12:in '<main>' ``` ## Versions ```console $ rdoc -v 6.10.0 ``` --------- Co-authored-by: Sutou Kouhei <[email protected]>
1 parent a047068 commit b6a8224

File tree

1 file changed

+16
-0
lines changed

1 file changed

+16
-0
lines changed

lib/rdoc/rubygems_hook.rb

Lines changed: 16 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -310,5 +310,21 @@ def self.generation_hook installer, specs
310310
# Generate document for compatibility if this is a default gem.
311311
RubyGemsHook.generate(installer, specs)
312312
end
313+
314+
def self.load_rdoc
315+
RubyGemsHook.load_rdoc
316+
end
317+
318+
def self.rdoc_version
319+
RubyGemsHook.rdoc_version
320+
end
321+
322+
def rdoc_installed?
323+
RubyGemsHook.new(@spec).rdoc_installed?
324+
end
325+
326+
def ri_installed?
327+
RubyGemsHook.new(@spec).ri_installed?
328+
end
313329
end
314330
end

0 commit comments

Comments
 (0)