diff --git a/lib/rdoc/markup/to_html.rb b/lib/rdoc/markup/to_html.rb index 9ae0fff8a7..3b1b0e9d40 100644 --- a/lib/rdoc/markup/to_html.rb +++ b/lib/rdoc/markup/to_html.rb @@ -52,12 +52,7 @@ def initialize options, markup = nil @th = nil @hard_break = "
\n" - # external links - @markup.add_regexp_handling(/(?:link:|https?:|mailto:|ftp:|irc:|www\.)\S+\w/, - :HYPERLINK) - - add_regexp_handling_RDOCLINK - add_regexp_handling_TIDYLINK + init_regexp_handlings init_tags end @@ -66,6 +61,24 @@ def initialize options, markup = nil # # These methods are used by regexp handling markup added by RDoc::Markup#add_regexp_handling. + ## + # Adds regexp handlings. + + def init_regexp_handlings + # external links + @markup.add_regexp_handling(/(?:link:|https?:|mailto:|ftp:|irc:|www\.)\S+\w/, + :HYPERLINK) + init_link_notation_regexp_handlings + end + + ## + # Adds regexp handlings about link notations. + + def init_link_notation_regexp_handlings + add_regexp_handling_RDOCLINK + add_regexp_handling_TIDYLINK + end + def handle_RDOCLINK url # :nodoc: case url when /^rdoc-ref:/ diff --git a/lib/rdoc/markup/to_html_crossref.rb b/lib/rdoc/markup/to_html_crossref.rb index 4a3f028135..77e3a94107 100644 --- a/lib/rdoc/markup/to_html_crossref.rb +++ b/lib/rdoc/markup/to_html_crossref.rb @@ -39,10 +39,18 @@ def initialize(options, from_path, context, markup = nil) @hyperlink_all = @options.hyperlink_all @show_hash = @options.show_hash - crossref_re = @hyperlink_all ? ALL_CROSSREF_REGEXP : CROSSREF_REGEXP + @cross_reference = RDoc::CrossReference.new @context + end + + def init_link_notation_regexp_handlings + add_regexp_handling_RDOCLINK + + # The crossref must be linked before tidylink because Klass.method[:sym] + # will be processed as a tidylink first and will be broken. + crossref_re = @options.hyperlink_all ? ALL_CROSSREF_REGEXP : CROSSREF_REGEXP @markup.add_regexp_handling crossref_re, :CROSSREF - @cross_reference = RDoc::CrossReference.new @context + add_regexp_handling_TIDYLINK end ## diff --git a/test/rdoc/test_rdoc_markup_to_html_crossref.rb b/test/rdoc/test_rdoc_markup_to_html_crossref.rb index 70306c683d..f6fabfb7db 100644 --- a/test/rdoc/test_rdoc_markup_to_html_crossref.rb +++ b/test/rdoc/test_rdoc_markup_to_html_crossref.rb @@ -151,6 +151,13 @@ def test_handle_regexp_CROSSREF_show_hash_false REGEXP_HANDLING('#m') end + def test_handle_regexp_CROSSREF_with_arg_looks_like_TIDYLINK + result = @to.convert 'C1.m[:sym]' + + assert_equal para("C1.m[:sym]"), result, + 'C1.m[:sym]' + end + def test_handle_regexp_HYPERLINK_rdoc readme = @store.add_file 'README.txt' readme.parser = RDoc::Parser::Simple