Skip to content

Diff -> HTML should respect line numbers from input #78

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
nathany opened this issue Oct 28, 2012 · 3 comments
Open

Diff -> HTML should respect line numbers from input #78

nathany opened this issue Oct 28, 2012 · 3 comments
Assignees
Milestone

Comments

@nathany
Copy link
Contributor

nathany commented Oct 28, 2012

Kornelius Kalnbach wrote:

I think we need some special tokens for that:

  • @encoder.line_number 308 || nil sets a new index, which is automatically increased for each line until another one is set.
  • nil turns off line numbers.
  • Maybe we need to send a @@encoder.there_will_be_line_numbers@, which would be equivalent to @encoder.line_number = nil.

TBD:

  • Do we ignore :line_number_start in such a case?

This is more complicated as we really need two columns (old/new line numbers) for this. Seems more like the Diff scanner will be some special thing in the future anyway.

From Redmine: http://odd-eyed-code.org/issues/310

@ghost ghost assigned korny Oct 28, 2012
@nathany
Copy link
Contributor Author

nathany commented Oct 28, 2012

Is this requirement superseded by Water?

@nathany
Copy link
Contributor Author

nathany commented Oct 28, 2012

Related to #69.

@korny
Copy link
Member

korny commented Nov 11, 2012

Is this requirement superseded by Water?

No.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants