From f31fe4687fdf0e6e5c798b58a93e6df2e7aad6db Mon Sep 17 00:00:00 2001
From: Elias Rohrer <dev@tnull.de>
Date: Mon, 10 Mar 2025 11:14:04 +0100
Subject: [PATCH] Add missing transaction categories

Contrary to Bitcoin Core's v17 docs, there are *5* transaction
categories that might be returned as part of a response to
`listtransactions`, `listsinceblock`, or `gettransaction`. While Core
fixed this omission in the docs in https://github.com/bitcoin/bitcoin/pull/14653,
we didn't account for them in the respective model's `enum`, leading to
calls to `get_transaction` randomly failing with the rather obscure
error message:
```
Err(JsonRpc(Json(Error("unknown variant `generate`, expected `send` or `receive`", line: 1, column: 682))))
```

Here, we fix this omission and add the missing categories.
---
 types/src/model/wallet.rs    | 10 ++++++++--
 types/src/v17/wallet/into.rs |  3 +++
 types/src/v17/wallet/mod.rs  | 10 ++++++++--
 3 files changed, 19 insertions(+), 4 deletions(-)

diff --git a/types/src/model/wallet.rs b/types/src/model/wallet.rs
index 039305a5..0d23e3f5 100644
--- a/types/src/model/wallet.rs
+++ b/types/src/model/wallet.rs
@@ -27,10 +27,16 @@ pub enum AddressPurpose {
 /// The category of a transaction.
 #[derive(Copy, Clone, PartialEq, Eq, Debug, Deserialize, Serialize)]
 pub enum TransactionCategory {
-    /// Transaction is a send.
+    /// Transactions sent.
     Send,
-    /// Transactions is a receive.
+    /// Non-coinbase transactions received.
     Receive,
+    /// Coinbase transactions received with more than 100 confirmations.
+    Generate,
+    /// Coinbase transactions received with 100 or fewer confirmations.
+    Immature,
+    /// Orphaned coinbase transactions received.
+    Orphan,
 }
 
 /// Whether this transaction can be RBF'ed.
diff --git a/types/src/v17/wallet/into.rs b/types/src/v17/wallet/into.rs
index 3130ca88..8f364673 100644
--- a/types/src/v17/wallet/into.rs
+++ b/types/src/v17/wallet/into.rs
@@ -37,6 +37,9 @@ impl TransactionCategory {
         match self {
             V::Send => M::Send,
             V::Receive => M::Receive,
+            V::Generate => M::Generate,
+            V::Immature => M::Immature,
+            V::Orphan => M::Orphan,
         }
     }
 }
diff --git a/types/src/v17/wallet/mod.rs b/types/src/v17/wallet/mod.rs
index acabd2d4..b3bb2e64 100644
--- a/types/src/v17/wallet/mod.rs
+++ b/types/src/v17/wallet/mod.rs
@@ -38,10 +38,16 @@ pub enum AddressPurpose {
 #[derive(Copy, Clone, PartialEq, Eq, Debug, Deserialize, Serialize)]
 #[serde(rename_all = "lowercase")]
 pub enum TransactionCategory {
-    /// Transaction is a send.
+    /// Transactions sent.
     Send,
-    /// Transactions is a receive.
+    /// Non-coinbase transactions received.
     Receive,
+    /// Coinbase transactions received with more than 100 confirmations.
+    Generate,
+    /// Coinbase transactions received with 100 or fewer confirmations.
+    Immature,
+    /// Orphaned coinbase transactions received.
+    Orphan,
 }
 
 /// Whether this transaction can be RBF'ed.