Skip to content

Use of soft-deprecated macro #101

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Riceman2000 opened this issue Jan 28, 2025 · 5 comments · Fixed by #102
Closed

Use of soft-deprecated macro #101

Riceman2000 opened this issue Jan 28, 2025 · 5 comments · Fixed by #102

Comments

@Riceman2000
Copy link
Contributor

The macro addr_of_mut!(expr) has been soft-deprecated and should be replaced with &raw mut expr.

Docs: https://doc.rust-lang.org/std/ptr/macro.addr_of_mut.html

@newAM
Copy link
Member

newAM commented Jan 28, 2025

Do you know when this syntax was introduced? I'm curious if it has an impact on the supported rust versions.

@Riceman2000
Copy link
Contributor Author

I have tried to find this, I opened a PR but I agree that if this alone affects MSRV it is not worth the change. I will continue to look.

@Riceman2000
Copy link
Contributor Author

I will leave this up to the maintainers but this feature was stabilized in 1.82.0. In the README.md the line "Starting with Rust 1.68..." could be taken as the MSRV, if this is the case, this would be a significant jump in MSRV for a minor change.

🤷

@Dirbaio
Copy link
Member

Dirbaio commented Feb 2, 2025

it's not a MSRV issue if it only affects the examples though?

@Riceman2000
Copy link
Contributor Author

Honestly I think not, but it could be frustrating to copy and paste the example code and get an error. Normally I would not care but the embedded software community loves to use older software versions.
Of course this could be solved with some comments in the docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants