-
Notifications
You must be signed in to change notification settings - Fork 57
Use of soft-deprecated macro #101
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Do you know when this syntax was introduced? I'm curious if it has an impact on the supported rust versions. |
I have tried to find this, I opened a PR but I agree that if this alone affects MSRV it is not worth the change. I will continue to look. |
I will leave this up to the maintainers but this feature was stabilized in 1.82.0. In the README.md the line "Starting with Rust 1.68..." could be taken as the MSRV, if this is the case, this would be a significant jump in MSRV for a minor change. 🤷 |
it's not a MSRV issue if it only affects the examples though? |
Honestly I think not, but it could be frustrating to copy and paste the example code and get an error. Normally I would not care but the embedded software community loves to use older software versions. |
The macro
addr_of_mut!(expr)
has been soft-deprecated and should be replaced with&raw mut expr
.Docs: https://doc.rust-lang.org/std/ptr/macro.addr_of_mut.html
The text was updated successfully, but these errors were encountered: