Skip to content

Commit bb36fd6

Browse files
committed
Have linkchecker skip discovery/print.html
rust-lang/mdBook#789 causes mdbook to generate print.html content with relative URLs that are still relative to the individual HTML files and doesn't correct for the fact that print.html isn't in the same folder. This commit will verify that the relative URLs are correct in all of the HTML output except for discovery/print.html I am assuming that people would like to see the images again in the Discovery book website as they click through the various chapters, even if the printable version is still broken. I have already made the same change to the CI scripts in the discovery repository along with various link fixes. Once this PR is merged, an issue should be created to track the fact that this change should be reverted once mdbook handles relative links correctly in its generaton of print.html
1 parent c4c7306 commit bb36fd6

File tree

1 file changed

+2
-1
lines changed

1 file changed

+2
-1
lines changed

ci/script.sh

+2-1
Original file line numberDiff line numberDiff line change
@@ -49,7 +49,8 @@ main() {
4949
rm -rf $tmpdir
5050

5151
# check links
52-
linkchecker doc
52+
# mdbook doesn't handle relative links correctly in print.html so skip it.
53+
linkchecker --ignore-url "discovery/print.html" doc
5354
}
5455

5556
main

0 commit comments

Comments
 (0)