You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Rollup merge of rust-lang#140773 - aDotInTheVoid:rdj-triagdfsadgs, r=dtolnay
triagebot: Better message for changes to `tests/rustdoc-json`
Followup to rust-lang#140689 / rust-lang#140606
Adds a message to changes to `tests/rustdoc-json`, instead of just pinging me. Hopefully this makes the significance of these tests clearer to people who otherwise wouldn't have context, so hopefully we can avoid that happening again. It's annoyingly hard to know how well this works, because the real test is seeing if it doesn't get ignored.
Predrag has [kindly offered](rust-lang#140689 (comment)) to also get pinged here.
cc ``@jyn514`` ``@obi1kenobi``
r? ``@GuillaumeGomez``
Copy file name to clipboardExpand all lines: triagebot.toml
+9-1
Original file line number
Diff line number
Diff line change
@@ -1001,7 +1001,15 @@ message = "This PR changes how GCC is built. Consider updating src/bootstrap/dow
1001
1001
message = "This PR changes a file inside `tests/crashes`. If a crash was fixed, please move into the corresponding `ui` subdir and add 'Fixes #<issueNr>' to the PR description to autoclose the issue upon merge."
1002
1002
1003
1003
[mentions."tests/rustdoc-json"]
1004
-
cc = ["@aDotInTheVoid"]
1004
+
message = """
1005
+
These commits modify `test/rustdoc-json`.
1006
+
rustdoc-json is a **public** (but unstable) interface.
1007
+
1008
+
Please ensure that if you've changed the output:
1009
+
- It's intentional.
1010
+
- The `FORMAT_VERSION` in `src/librustdoc-json-types` is bumped if necessary.
0 commit comments