Skip to content

Commit 5c6a99d

Browse files
committed
address some of the review comments
1 parent d4f8e77 commit 5c6a99d

File tree

1 file changed

+9
-8
lines changed

1 file changed

+9
-8
lines changed

posts/2019-09-18-upcoming-docsrs-changes.md

+9-8
Original file line numberDiff line numberDiff line change
@@ -17,18 +17,19 @@ build as many crates as possible. It's already used by [Crater], and we added
1717
all the dependencies previously installed in the legacy build environment.
1818

1919
To ensure we can continue operating the service in the future and to increase
20-
its reliability we also improved the sandbox builds are executed into, adding
20+
its reliability we also improved the sandbox builds are executed in, adding
2121
new limits:
2222

2323
* Each platform will now have **15 minutes** to build its dependencies and
2424
documentation.
2525
* **3 GB of RAM** will be available for the build.
26-
* Network access will be completly **disabled**.
26+
* Network access will be **disabled** (crates.io dependencies will still be
27+
fetched).
2728
* Only the `target/` directory will be writable, and it will be purged after
2829
each build.
2930

3031
Finally, docs.rs will now use the latest nightly available when building
31-
crates.
32+
crates, instead of using a manually updated pinned version of nightly.
3233

3334
## How to prepare for the changes
3435

@@ -48,14 +49,14 @@ documentation:
4849
cargo doc --no-deps
4950
```
5051

51-
If a dependency is missing please [open an issue][crates-build-env-issue] on
52-
the Docker image's repository.
52+
If a dependency is missing, please [open an issue][crates-build-env-issue] on
53+
the Docker image's [repository][rustops/crates-build-env].
5354

5455
If your crate fails to build because it took more than 15 minutes to generate
5556
its docs or it uses more than 3 GB of RAM please [open an issue][docsrs-issue]
56-
and we will increase the limits for your crate (when it's reasonable). We will
57-
**not** enable network access for your crate though: you'll need to change your
58-
crate not to require any external resource at build time.
57+
and we will consider reasonable limit increases for your crate. We will **not**
58+
enable network access for your crate though: you'll need to change your crate
59+
not to require any external resource at build time.
5960

6061
## Acknowledgements
6162

0 commit comments

Comments
 (0)