Skip to content

Commit 73f68dd

Browse files
committed
auto merge of #1010 : alexcrichton/cargo/mingw, r=brson
This prevents having mismatches between bundled libs and libs on the system (Cargo requires MinGW to compile regardless).
2 parents 70f5205 + 673d318 commit 73f68dd

File tree

5 files changed

+9
-7
lines changed

5 files changed

+9
-7
lines changed

.travis.install.deps.sh

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -60,6 +60,8 @@ else
6060
mv '{app}' rustc
6161
# Don't use the bundled gcc, see rust-lang/rust#17442
6262
rm -rf rustc/bin/rustlib/$triple/bin
63+
# Don't use bundled gcc libs, see rust-lang/rust#19519
64+
rm -rf rustc/bin/rustlib/$triple/libmingw*.a
6365
rm -f rust-nightly-$triple.exe
6466
fi
6567

Cargo.lock

Lines changed: 2 additions & 2 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

src/cargo/sources/git/utils.rs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -415,7 +415,7 @@ pub fn fetch(repo: &git2::Repository, url: &str,
415415
let mut remote = try!(repo.remote_anonymous(url.as_slice(), refspec));
416416
try!(remote.add_fetch("refs/tags/*:refs/tags/*"));
417417
remote.set_callbacks(&mut cb);
418-
try!(remote.fetch(None, None));
418+
try!(remote.fetch(&["refs/tags/*:refs/tags/*", refspec], None, None));
419419
Ok(())
420420
})
421421
}

tests/test_cargo_build_auth.rs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -169,7 +169,7 @@ Caused by:
169169
",
170170
addr = addr,
171171
errmsg = if cfg!(windows) {
172-
"Failed to send request: The connection with the server \
172+
"failed to send request: The connection with the server \
173173
was terminated abnormally\n"
174174
} else {
175175
"SSL error: [..]"

tests/test_cargo_compile_git_deps.rs

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -42,7 +42,7 @@ fn add(repo: &git2::Repository) {
4242
}
4343
let mut index = repo.index().unwrap();
4444
index.add_all(&["*"], git2::ADD_DEFAULT, Some(|a: &[u8], _b: &[u8]| {
45-
if s.iter().any(|s| s.path().as_vec() == a) {1} else {0}
45+
if s.iter().any(|s| a.starts_with(s.path().as_vec())) {1} else {0}
4646
})).unwrap();
4747
index.write().unwrap();
4848
}
@@ -53,7 +53,7 @@ fn add_submodule<'a>(repo: &'a git2::Repository, url: &str,
5353
let subrepo = s.open().unwrap();
5454
let mut origin = subrepo.find_remote("origin").unwrap();
5555
origin.add_fetch("refs/heads/*:refs/heads/*").unwrap();
56-
origin.fetch(None, None).unwrap();
56+
origin.fetch(&[], None, None).unwrap();
5757
origin.save().unwrap();
5858
subrepo.checkout_head(None).unwrap();
5959
s.add_finalize().unwrap();
@@ -979,7 +979,7 @@ test!(dep_with_changed_submodule {
979979
let mut origin = subrepo.find_remote("origin").unwrap();
980980
origin.set_url(git_project3.url().to_string().as_slice()).unwrap();
981981
origin.add_fetch("refs/heads/*:refs/heads/*").unwrap();;
982-
origin.fetch(None, None).unwrap();
982+
origin.fetch(&[], None, None).unwrap();
983983
origin.save().unwrap();
984984
let id = subrepo.refname_to_id("refs/remotes/origin/master").unwrap();
985985
let obj = subrepo.find_object(id, None).unwrap();

0 commit comments

Comments
 (0)