Cargo fmt no longer supports --manifest-path

[corasaurus-hex]

It seems like cargo fmt ought to support --manifest-path but it seems to be broken from what I can tell: rust-lang/rustfmt#2817

This is using cargo 1.29.0 (524a578d7 2018-08-05) and rustfmt 0.99.1-stable (da17b689 2018-08-04).

[corasaurus-hex]

Specifically:

$ cargo run --manifest-path Code/exercism/rust/saddle-points/Cargo.toml
error: a bin target must be available for `cargo run`
~
$ cargo clippy --manifest-path Code/exercism/rust/saddle-points/Cargo.toml
    Checking saddle-points v1.3.0 (file:///Users/nsutton/Code/exercism/rust/saddle-points)
error: expected expression, found `)`
  --> src/lib.rs:13:9
   |
13 |         );
   |         ^ expected expression

error: aborting due to previous error

error: Could not compile `saddle-points`.

To learn more, run the command again with --verbose.
~
$ cargo fmt --manifest-path Code/exercism/rust/saddle-points/Cargo.toml
Invalid argument: `Code/exercism/rust/saddle-points/Cargo.toml`.
usage: cargo fmt [options]

Options:
    -h, --help          show this message
    -q, --quiet         no output printed to stdout
    -v, --verbose       use verbose output
    -p, --package <package>
                        specify package to format (only usable in workspaces)
        --version       print rustfmt version and exit
        --all           format all packages (only usable in workspaces)

This utility formats all bin and lib files of the current crate using rustfmt. Arguments after `--` are passed to rustfmt.
~
$

See how cargo fmt sees it as an invalid argument?

[ehuss]

I don't think this is a cargo issue. rustfmt ships the cargo-fmt command. It needs to be updated as described in the linked rustfmt issue.

[corasaurus-hex]

Yeah, seems like the issue is in cargo-fmt in rustfmt. Do you mean updated as in to use the package option? I don't think that applies here.

[ehuss]

cargo-fmt would need to be updated to add a --manifest-path option (probably somewhere in here), and then it would need to pass the path into get_cargo_metadata in this file where it currently passes None.

[corasaurus-hex]

Cool, thanks for the tips. I'm trying to put together my first patch for a rust project. :) rust-lang/rustfmt@master...nate:accept-manifest-path

[dwijnand]

Nice!