Skip to content

Remove TargetInterner #643

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
detrumi opened this issue Oct 30, 2020 · 1 comment · Fixed by #648
Closed

Remove TargetInterner #643

detrumi opened this issue Oct 30, 2020 · 1 comment · Fixed by #648
Assignees
@LeSeulArtichaut
Labels
good first issue A good issue to start working on Chalk with

Comments

@detrumi
Copy link
Member

detrumi commented Oct 30, 2020 •
edited by rustbot
Loading

The TargetInterner in the Fold traits is problematic for the shared type library, so we should remove it.

  • Remove the TargetInterner trait
  • Traits that take a TargetInterner as argument should use the Interner instead (so Fold<I: Interner, TI: TargetInterner<I> = I> becomes Fold<I: Interner>)
  • Comments mentioning TargetInterner/TI should be simplified
  • The derive_fold macro should not generate TargetInterner bounds any more
@detrumi detrumi added the good first issue A good issue to start working on Chalk with label Oct 30, 2020
@LeSeulArtichaut
Copy link
Contributor

@rustbot claim

@LeSeulArtichaut LeSeulArtichaut mentioned this issue Nov 4, 2020
Merged
@bors bors closed this as completed in 1c91d87 Nov 5, 2020
@bors bors closed this as completed in #648 Nov 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@LeSeulArtichaut LeSeulArtichaut

Labels
good first issue A good issue to start working on Chalk with
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Remove TargetInterner LeSeulArtichaut/chalk
2 participants
@detrumi @LeSeulArtichaut