Skip to content

Transfer on-disk hash table implementation (odht crate) to rust-lang org #438

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
3 tasks done
michaelwoerister opened this issue Jun 9, 2021 · 4 comments
Closed
3 tasks done

Transfer on-disk hash table implementation (odht crate) to rust-lang org #438

michaelwoerister opened this issue Jun 9, 2021 · 4 comments
Labels
major-change A proposal to make a major change to rustc major-change-accepted A major change proposal that was accepted T-compiler Add this label so rfcbot knows to poll the compiler team

Comments

@michaelwoerister
Copy link
Member

michaelwoerister commented Jun 9, 2021 •
edited
Loading

Proposal

I would like to transfer my "on-disk" hash table implementation to the rust-lang GH organization. The crate is production-ready and is useful for encoding and decoding data in incr. comp. caches and crate metadata. The first use case for it is rust-lang/rust#82183 where it allows simplifying the existing code while making it faster at the same time.

I don't expect this crate to require much maintenance - but it would certainly be good to give it a good review before the transfer.

Mentors or Reviewers

@wesleywiser has agreed to review this MCP.

Process

The main points of the Major Change Process are as follows:

  • File an issue describing the proposal.
  • A compiler team member or contributor who is knowledgeable in the area can second by writing @rustbot second.
    • Finding a "second" suffices for internal changes. If however, you are proposing a new public-facing feature, such as a -C flag, then full team check-off is required.
    • Compiler team members can initiate a check-off via @rfcbot fcp merge on either the MCP or the PR.
  • Once an MCP is seconded, the Final Comment Period begins. If no objections are raised after 10 days, the MCP is considered approved.

You can read more about Major Change Proposals on forge.

Comments

This issue is not meant to be used for technical discussion. There is a Zulip stream for that. Use this issue to leave procedural comments, such as volunteering to review, indicating that you second the proposal (or third, etc), or raising a concern that you would like to be addressed.
@michaelwoerister michaelwoerister added T-compiler Add this label so rfcbot knows to poll the compiler team major-change A proposal to make a major change to rustc labels Jun 9, 2021
@rustbot
Copy link
Collaborator

rustbot commented Jun 9, 2021

This issue is not meant to be used for technical discussion. There is a Zulip stream for that. Use this issue to leave procedural comments, such as volunteering to review, indicating that you second the proposal (or third, etc), or raising a concern that you would like to be addressed.

cc @rust-lang/compiler @rust-lang/compiler-contributors

@rustbot rustbot added the to-announce Announce this issue on triage meeting label Jun 9, 2021
@michaelwoerister michaelwoerister changed the title (My major change proposal) Transfer on-disk hash table implementation (odht crate) to rust-lang org Jun 9, 2021
@jonas-schievink
Copy link
Contributor

cc rust-lang/rfcs#3119

@wesleywiser
Copy link
Member

@rustbot second

This seems like a good fit for the "Internal Use - Not transitively intentional" category of crates outlined in RFC 3119.

@rustbot rustbot added the final-comment-period The FCP has started, most (if not all) team members are in agreement label Jun 9, 2021
@apiraino apiraino removed the to-announce Announce this issue on triage meeting label Jun 10, 2021
@apiraino
Copy link
Contributor

@rustbot label -final-comment-period +major-change-accepted

@rustbot rustbot added major-change-accepted A major change proposal that was accepted to-announce Announce this issue on triage meeting and removed final-comment-period The FCP has started, most (if not all) team members are in agreement labels Jun 29, 2021
@apiraino apiraino removed the to-announce Announce this issue on triage meeting label Jul 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
major-change A proposal to make a major change to rustc major-change-accepted A major change proposal that was accepted T-compiler Add this label so rfcbot knows to poll the compiler team
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@wesleywiser @jonas-schievink @michaelwoerister @apiraino @rustbot