Allow webhook to link to list of crates

Author: ecstatic-morse

src/server/routes/webhooks/args.rs

@@ -1,5 +1,52 @@
 use crate::experiments::{Assignee, CapLints, CrateSelect, Mode};
 use crate::toolchain::Toolchain;
+use failure::{self, Fallible};
+use reqwest;
+use url::Url;
+
+#[derive(Debug, PartialEq, Eq, Hash, Clone)]
+pub enum DeferredCrateSelect {
+    Direct(CrateSelect),
+    Indirect(Url),
+}
+
+impl From<CrateSelect> for DeferredCrateSelect {
+    fn from(v: CrateSelect) -> Self {
+        DeferredCrateSelect::Direct(v)
+    }
+}
+
+impl DeferredCrateSelect {
+    pub fn resolve(self) -> Fallible<CrateSelect> {
+        let url = match self {
+            DeferredCrateSelect::Direct(v) => return Ok(v),
+            DeferredCrateSelect::Indirect(url) => url,
+        };
+
+        let body = reqwest::get(url)?.text()?;
+        if body.contains(",") {
+            bail!("Crate identifiers must not contain a comma");
+        }
+
+        let crates = body
+            .split(|c: char| c.is_whitespace())
+            .map(|s| s.to_owned())
+            .collect();
+        Ok(CrateSelect::List(crates).into())
+    }
+}
+
+impl FromStr for DeferredCrateSelect {
+    type Err = failure::Error;
+
+    fn from_str(input: &str) -> Fallible<Self> {
+        if input.starts_with("https://") || input.starts_with("http://") {
+            Ok(DeferredCrateSelect::Indirect(input.parse()?))
+        } else {
+            Ok(DeferredCrateSelect::Direct(input.parse()?))
+        }
+    }
+}
 
 #[derive(Debug, Fail)]
 #[cfg_attr(test, derive(PartialEq, Eq))]
@@ -107,7 +154,7 @@ generate_parser!(pub enum Command {
         start: Option<Toolchain> = "start",
         end: Option<Toolchain> = "end",
         mode: Option<Mode> = "mode",
-        crates: Option<CrateSelect> = "crates",
+        crates: Option<DeferredCrateSelect> = "crates",
         cap_lints: Option<CapLints> = "cap-lints",
         priority: Option<i32> = "p",
         ignore_blacklist: Option<bool> = "ignore-blacklist",
@@ -136,7 +183,7 @@ generate_parser!(pub enum Command {
         start: Option<Toolchain> = "start",
         end: Option<Toolchain> = "end",
         mode: Option<Mode> = "mode",
-        crates: Option<CrateSelect> = "crates",
+        crates: Option<DeferredCrateSelect> = "crates",
         cap_lints: Option<CapLints> = "cap-lints",
         priority: Option<i32> = "p",
         ignore_blacklist: Option<bool> = "ignore-blacklist",

src/server/routes/webhooks/commands.rs

@@ -56,6 +56,11 @@ pub fn run(
 
     // Make crater runs created via webhook require linux by default.
     let requirement = args.requirement.unwrap_or_else(|| "linux".to_string());
+    let crates = args
+        .crates
+        .map(|c| c.resolve())
+        .transpose()
+        .map_err(|e| e.context("Failed to resolve crate list"))?;
 
     actions::CreateExperiment {
         name: name.clone(),
@@ -68,7 +73,7 @@ pub fn run(
                 .ok_or_else(|| err_msg("missing end toolchain"))?,
         ],
         mode: args.mode.unwrap_or(Mode::BuildAndTest),
-        crates: args.crates.unwrap_or(CrateSelect::Full),
+        crates: crates.unwrap_or(CrateSelect::Full),
         cap_lints: args.cap_lints.unwrap_or(CapLints::Forbid),
         priority: args.priority.unwrap_or(0),
         github_issue: Some(GitHubIssue {
@@ -104,10 +109,16 @@ pub fn run(
 pub fn edit(data: &Data, issue: &Issue, args: EditArgs) -> Fallible<()> {
     let name = get_name(&data.db, issue, args.name)?;
 
+    let crates = args
+        .crates
+        .map(|c| c.resolve())
+        .transpose()
+        .map_err(|e| e.context("Failed to resolve crate list"))?;
+
     actions::EditExperiment {
         name: name.clone(),
         toolchains: [args.start, args.end],
-        crates: args.crates,
+        crates,
         mode: args.mode,
         cap_lints: args.cap_lints,
         priority: args.priority,