Skip to content

Commit 24acfee

Browse files
committed
Allow renamed lints and enable clippy-preview on stable
Allow renamed_and_removed_lints because new warnings on nightly recommend the new clippy::* attribute syntax, which is not yet stable (and we turn all warnings into hard errors). Additionally, clippy-preview is now installed and run on stable. We were previously running clippy on an old nightly from late June and no new warnings (except the one noted above) are raised on nightly so switching to the -preview component on stable shouldn't introduce churn. Also, unlike with rustfmt, we can fix and merge any clippy recommendations before they hit the stable channel, so we don't have to sync with new releases.
1 parent 4bcb22a commit 24acfee

File tree

3 files changed

+6
-4
lines changed

3 files changed

+6
-4
lines changed

.travis.yml

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -47,16 +47,14 @@ matrix:
4747
allow_failures:
4848
- rust: nightly
4949
include:
50-
- rust: nightly-2018-06-26
51-
script:
52-
- cargo install --force clippy --vers 0.0.210
53-
- cargo clippy
5450
- rust: stable
5551
before_install:
5652
- nvm install 10
5753
- rustup component add rustfmt-preview
54+
- rustup component add clippy-preview
5855
script:
5956
- cargo fmt -- --check
57+
- cargo clippy
6058
- cargo build
6159
- cargo test
6260
- npm install

src/lib.rs

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -7,6 +7,8 @@
77
#![deny(missing_debug_implementations, missing_copy_implementations)]
88
#![deny(bare_trait_objects)]
99
#![recursion_limit = "256"]
10+
11+
#![allow(renamed_and_removed_lints)] // This can be removed once the new clippy:: lint sytnax is stable
1012
#![allow(unknown_lints, proc_macro_derive_resolution_fallback)] // This can be removed after diesel-1.4
1113

1214
extern crate ammonia;

src/tests/all.rs

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,6 @@
11
#![deny(warnings)]
2+
3+
#![allow(renamed_and_removed_lints)] // This can be removed once the new clippy:: lint sytnax is stable
24
#![allow(unknown_lints, proc_macro_derive_resolution_fallback)] // This can be removed after diesel-1.4
35

46
extern crate cargo_registry;

0 commit comments

Comments
 (0)