Skip to content

Something about the ember upgrade broke navigating between pages sometimes :-/ #768

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
carols10cents opened this issue Jun 11, 2017 · 2 comments
Labels
A-frontend 🐹 C-bug 🐞 Category: unintended, undesired behavior

Comments

@carols10cents
Copy link
Member

@locks halp :(

I rolled this back on production, but I have commit 1ac9e50 deployed to https://staging-crates-io.herokuapp.com/ if you/anyone wants to take a look. I am also able to reproduce running the frontend locally with yarn run start:live.

One way to reproduce:

  • Visit https://staging-crates-io.herokuapp.com/
  • Click on "Browse All Crates" at the top, this works fine
  • Click on any crate's link
    • The URL changes as expected
    • The page scrolls back to the top as expected
    • I see ajax requests to /api/v1/crates/:crate_name and /api/v1/crates/:crate_name/version happen, so it's trying to load something, but I'm expecting ajax requests to the crate's authors, owners, reverse dependencies, dependencies, and downloads too :(
    • The page content does not change to the crate page's content and remains as the browse all crates page's content, unexpected :(

I am able to reproduce the unexpected behavior in both firefox 53.0.3 and chrome 58.0.3029.110 (64-bit) on macos.

@carols10cents
Copy link
Member Author

I've reverted the merge in 1ac9e50 (the merge of the PR of the ember upgrade) so that I can deploy other stuff while we figure this out.

@carols10cents carols10cents added C-bug 🐞 Category: unintended, undesired behavior A-frontend 🐹 labels Jun 13, 2017
@carols10cents
Copy link
Member Author

Fixed by #779 !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-frontend 🐹 C-bug 🐞 Category: unintended, undesired behavior
Projects
None yet
Development

No branches or pull requests

1 participant