Fix rustdoc styles for very old docs

jyn514 · jyn514 · commit aef68ffb77b5 · 2020-09-19T02:34:37.000-04:00
Previously this used the selector
`link[type='text/css'][href*='normalize']` to inject the vendored HTML.
Unfortunately, this selector did not exist in very old versions of
rustdoc. Instead, this now adds the `vendored.css` stylesheet at the
start of the `&lt;head&gt;` tag.
diff --git a/src/utils/html.rs b/src/utils/html.rs
@@ -19,12 +19,13 @@ pub(crate) fn rewrite_lol(
 
     let templates = templates.templates.load();
     let tera_head = templates.render("rustdoc/head.html", &ctx).unwrap();
-    let tera_vendored_css = templates.render("rustdoc/vendored.html", &ctx).unwrap();
+    let tera_vendored = templates.render("rustdoc/vendored.html", &ctx).unwrap();
     let tera_body = templates.render("rustdoc/body.html", &ctx).unwrap();
     let tera_rustdoc_header = templates.render("rustdoc/header.html", &ctx).unwrap();
 
     // Append `style.css` stylesheet after all head elements.
     let head_handler = |head: &mut Element| {
+        head.prepend(&tera_vendored, ContentType::Html);
         head.append(&tera_head, ContentType::Html);
 
         Ok(())
@@ -64,18 +65,7 @@ pub(crate) fn rewrite_lol(
         Ok(())
     };
 
-    // Append `vendored.css` before the first stylesheet (rustdoc's first stylesheet is `normalize.css`).
-    let first_stylesheet_handler = |head: &mut Element| {
-        head.before(&tera_vendored_css, ContentType::Html);
-
-        Ok(())
-    };
-
-    let (head_selector, body_selector, first_stylesheet_selector) = (
-        "head".parse().unwrap(),
-        "body".parse().unwrap(),
-        "link[type='text/css'][href*='normalize']".parse().unwrap(),
-    );
+    let (head_selector, body_selector) = ("head".parse().unwrap(), "body".parse().unwrap());
     let element_content_handlers = vec![
         (
             &head_selector,
@@ -85,10 +75,6 @@ pub(crate) fn rewrite_lol(
             &body_selector,
             ElementContentHandlers::default().element(body_handler),
         ),
-        (
-            &first_stylesheet_selector,
-            ElementContentHandlers::default().element(first_stylesheet_handler),
-        ),
     ];
     let settings = Settings {
         element_content_handlers,
