Skip to content

delete version doesn't remove the owner if there are no more releases with that owner #900

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
jyn514 opened this issue Jul 17, 2020 · 2 comments · Fixed by #917
Closed

delete version doesn't remove the owner if there are no more releases with that owner #900

jyn514 opened this issue Jul 17, 2020 · 2 comments · Fixed by #917
Labels
A-admin Area: Administration of the production docs.rs server C-bug Category: This is a bug P-medium Medium priority S-blocked Status: marked as blocked ❌ on something else such as an RFC or other implementation work.

Comments

@jyn514
Copy link
Member

jyn514 commented Jul 17, 2020

See for example https://docs.rs/crate/pioneer/0.0.1 which still says it was authored by @polygraphy. This may need #766 to fix.

Originally posted by @jyn514 in #837 (comment)
@jyn514 jyn514 added A-admin Area: Administration of the production docs.rs server P-medium Medium priority C-bug Category: This is a bug labels Jul 17, 2020
@Nemo157
Copy link
Member

Nemo157 commented Jul 18, 2020 •
edited
Loading

Ownership isn't linked to releases in any way, it's per-crate and mutable on crates.io. It just happens to only be updated from crates.io when we build a new release. We could add a update-crates-io-data to the CLI similar to the existing update-github-fields (though probably taking a crate name to update rather than updating all of them 🤣) (or just wait till that's handled by #766 as well).

@jyn514
Copy link
Member Author

jyn514 commented Jul 18, 2020

Ah I hadn't considered that ownership can change at any time. Yeah in that case I think we should make this part of #766 .

@jyn514 jyn514 mentioned this issue Jul 18, 2020
Closed
@jyn514 jyn514 added the S-blocked Status: marked as blocked ❌ on something else such as an RFC or other implementation work. label Jul 18, 2020
@Nemo157 Nemo157 mentioned this issue Jul 28, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-admin Area: Administration of the production docs.rs server C-bug Category: This is a bug P-medium Medium priority S-blocked Status: marked as blocked ❌ on something else such as an RFC or other implementation work.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Update owner details more fully during build and add CLI command to trigger it Nemo157/docs.rs
2 participants
@Nemo157 @jyn514