Skip to content

Support for easier re-rollups #89

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
RalfJung opened this issue Jun 13, 2020 · 3 comments · Fixed by #112
Closed

Support for easier re-rollups #89

RalfJung opened this issue Jun 13, 2020 · 3 comments · Fixed by #112
Labels
good first issue Good for newcomers help wanted Extra attention is needed

Comments

@RalfJung
Copy link
Member

Re-rollups (rolling up with a very similar set of PRs, because one of them failed or so) are currently quite painful. It would be great to get better support from bors for that.

@pietroalbini had a great idea for this that does not require extra server-side state:

add a "Create a similar rollup" link in the rollup PR body, with the link going to https://bors.rust-lang.org/queue/rust?prs=12345,6583,342345

@pietroalbini
Copy link
Member

To implement this, two changes are needed:

  • When the PR message is generated include an URL to the queue page with the list of PRs included in the rollup in the query string. You'll need to gather the current base URL for that (you can add a field in the configuration for it).
  • In the queue page extract the list of PRs from the query string (if present), and pass it to the template. In the template check the checkbox if the PR is in the list.

If you have any questions feel free to ping me or ask on Zulip!

@pietroalbini pietroalbini added good first issue Good for newcomers help wanted Extra attention is needed labels Jun 15, 2020
@Manishearth
Copy link
Member

An important thing to note is that the JS should only check the checkbox for PRs which are approved or not-try pending

@oliviacrain
Copy link
Contributor

It looks like no one has taken this up- I'll take a crack at this tonight!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants