Skip to content

Make MathJax optional #347

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
budziq opened this issue Jun 23, 2017 · 2 comments · Fixed by #363
Closed

Make MathJax optional #347

budziq opened this issue Jun 23, 2017 · 2 comments · Fixed by #363
Labels
A-JavaScript Area: Javascript A-Performance Area: Zoom Zoom C-enhancement Category: Enhancement or feature request S-Wishlist Status: Wishlist

Comments

@budziq
Copy link
Contributor

budziq commented Jun 23, 2017 •
edited
Loading

Basically like in case of ACE.
MathJax is a large dependency that might be seldom required

Additionally it blocks offline reading rust-lang/book#711 due to how it is incrementally loaded from cdn.

It would be preferable to have MathJax as an optional dependency with key in the book.toml.

blocked on https://github.com/azerupi/mdBook/pull/335 - will need to wait until curent hbs_renderer refactor is finished.
@azerupi azerupi added A-JavaScript Area: Javascript A-Performance Area: Zoom Zoom S-Wishlist Status: Wishlist C-enhancement Category: Enhancement or feature request labels Jun 23, 2017
@budziq budziq mentioned this issue Jun 23, 2017
Merged
@Michael-F-Bryan
Copy link
Contributor

#335 just got merged, so it should no longer be blocking this.

@budziq
Copy link
Contributor Author

budziq commented Jun 24, 2017

#335 just got merged, so it should no longer be blocking this.

Yup ;) I'll look into this issue later on.

@budziq budziq mentioned this issue Jun 24, 2017
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-JavaScript Area: Javascript A-Performance Area: Zoom Zoom C-enhancement Category: Enhancement or feature request S-Wishlist Status: Wishlist
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Make MathJax support optional budziq/mdBook
3 participants
@budziq @azerupi @Michael-F-Bryan