Theme directory behavior does not match documentation #695

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Closed

mattico opened this issue May 14, 2018 · 0 comments

Contributor

mattico commented May 14, 2018 •

edited

Loading

The guide says:

The theme is totally customizable, you can selectively replace every file from the theme by your own by adding a theme directory next to src folder in your project root.

However, the actual implementation looks for a theme directory inside of src:

https://github.com/rust-lang-nursery/mdBook/blob/b9ca108fcae2b738ca3f0c88c84ae5dc5a6f843f/src/renderer/html_handlebars/hbs_renderer.rs#L274-L277

Which was changed in #491, and we just haven't noticed yet!?

This was referenced May 14, 2018

Update mdBook to 0.1.7 rust-lang/rust-by-example#1080

Closed

Fix default theme dir selection #696

Merged

azerupi closed this as completed in #696

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment